Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(server): add custom HTTP headers into error response #7214

Merged
merged 3 commits into from Apr 13, 2020
Merged

feat(server): add custom HTTP headers into error response #7214

merged 3 commits into from Apr 13, 2020

Conversation

NicoPennec
Copy link

This PR add the capability to set a list of custom HTTP header on Error middleware when throw error.

Types of changes

  • Bug fix (a non-breaking change which fixes an issue)
  • New feature (a non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Description

Resolves: #7213

Checklist:

  • My change requires a change to the documentation.
  • I have updated the documentation accordingly. (PR: #)
  • I have added tests to cover my changes (if not applicable, please state why)
  • All new and existing tests are passing.

@codecov-io
Copy link

Codecov Report

Merging #7214 into dev will increase coverage by 0.03%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##              dev    #7214      +/-   ##
==========================================
+ Coverage   62.83%   62.86%   +0.03%     
==========================================
  Files          84       84              
  Lines        3406     3409       +3     
  Branches      930      931       +1     
==========================================
+ Hits         2140     2143       +3     
  Misses       1018     1018              
  Partials      248      248              
Flag Coverage Δ
#unittests 62.86% <100.00%> (+0.03%) ⬆️
Impacted Files Coverage Δ
packages/server/src/middleware/error.js 98.30% <100.00%> (+0.09%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c02ded2...7f54caa. Read the comment docs.

@Atinux Atinux requested review from clarkdo, Atinux and pi0 April 13, 2020 18:42
Atinux
Atinux previously approved these changes Apr 13, 2020
Copy link
Member

@Atinux Atinux left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking good for me :)

pi0
pi0 previously approved these changes Apr 13, 2020
clarkdo
clarkdo previously approved these changes Apr 13, 2020
@pi0 pi0 dismissed stale reviews from clarkdo, Atinux, and themself via f30c558 April 13, 2020 18:49
@pi0 pi0 merged commit 1002d3f into nuxt:dev Apr 13, 2020
@pi0
Copy link
Member

pi0 commented Apr 13, 2020

Thanks @NicoPennec ❤️

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add custom HTTP headers into response error
6 participants