-
-
Notifications
You must be signed in to change notification settings - Fork 5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(webpack): reduce false negatives in nodeExternals (#7462) #7464
Conversation
Codecov Report
@@ Coverage Diff @@
## dev #7464 +/- ##
==========================================
- Coverage 70.32% 70.28% -0.05%
==========================================
Files 88 88
Lines 3704 3708 +4
Branches 1010 1011 +1
==========================================
+ Hits 2605 2606 +1
- Misses 892 894 +2
- Partials 207 208 +1
Continue to review full report at Codecov.
|
@pi0 is there anything more to do for me or can this be merged? |
@JohannesLamberts No, actually it is perfect. Would be nice removing |
@pi0 done, I also removed the RegEx to reduce complexity |
Amazing thanks ❤️ Waiting for tests to pass |
@pi0 https://github.com/nuxt/nuxt.js/pull/7464/checks?check_run_id=750834024 failed with
I cannot see how this could be related to the code changes :/ |
Types of changes
This could change behaviour in existing SSR-Apps. The behaviour is however undocumented and unintended (afaik).
Description
Resolves: #7462
Checklist:
I'm not sure how/if the changes can be tested and would be grateful for guiding/support.