-
-
Notifications
You must be signed in to change notification settings - Fork 5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
types: import types for @nuxt/telemetry
and @nuxt/components
#7626
Conversation
Codecov Report
@@ Coverage Diff @@
## dev #7626 +/- ##
=======================================
Coverage 70.28% 70.28%
=======================================
Files 88 88
Lines 3749 3749
Branches 1020 1019 -1
=======================================
Hits 2635 2635
- Misses 905 906 +1
+ Partials 209 208 -1
Continue to review full report at Codecov.
|
packages/types/config/index.d.ts
Outdated
@@ -32,6 +34,7 @@ export interface NuxtOptions extends Configuration { | |||
buildDir: string | |||
buildModules: NuxtOptionsModule[] | |||
cli: NuxtOptionsCli | |||
components: boolean | Array<string | ComponentsDir> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There is also object format support (which may be used later on to provide more options
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ideally the options would be completely defined in @nuxt/components
and just imported in @nuxt/types
. I will propose a PR to do that if that sounds good to you.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Indeed. Just published types for both 🙈 Updating deps in a sec.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@nuxt/telemetry
and @nuxt/components
@nuxt/telemetry
and @nuxt/components
@nuxt/telemetry
and @nuxt/components
@nuxt/telemetry
and @nuxt/components
Add missing types for new Nuxt modules
@nuxt/telemetry
and@nuxt/components
.Types of changes
Description
Added two new properties to
NuxtConfig
type.Checklist: