feat(webpack): auto detect core-js version #7785

farnabaz · 2020-07-27T10:34:01Z

Provide easy way to change core-js version and auto detect core-js installed version

Types of changes

Bug fix (a non-breaking change which fixes an issue)
New feature (a non-breaking change which adds functionality)
Breaking change (fix or feature that would cause existing functionality to change)

Description

Checklist:

My change requires a change to the documentation.
I have updated the documentation accordingly. (PR: #)
I have added tests to cover my changes (if not applicable, please state why)
All new and existing tests are passing.

packages/webpack/src/config/base.js

codecov-commenter · 2020-07-27T12:24:25Z

Codecov Report

Merging #7785 into dev will decrease coverage by 1.29%.
The diff coverage is 39.33%.

@@            Coverage Diff             @@
##              dev    #7785      +/-   ##
==========================================
- Coverage   70.17%   68.88%   -1.30%     
==========================================
  Files          88       90       +2     
  Lines        3762     3834      +72     
  Branches     1022     1037      +15     
==========================================
+ Hits         2640     2641       +1     
- Misses        912      969      +57     
- Partials      210      224      +14

Flag	Coverage Δ
#unittests	`68.88% <39.33%> (-1.30%)`	⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files	Coverage Δ
packages/cli/src/utils/generate.js	`0.00% <0.00%> (ø)`
packages/config/src/config/build.js	`100.00% <ø> (ø)`
packages/config/src/config/generate.js	`100.00% <ø> (ø)`
packages/core/src/nuxt.js	`93.18% <ø> (ø)`
packages/vue-app/src/index.js	`100.00% <ø> (ø)`
packages/vue-renderer/src/renderer.js	`0.00% <0.00%> (ø)`
packages/vue-renderer/src/renderers/spa.js	`0.00% <0.00%> (ø)`
packages/cli/src/commands/generate.js	`88.23% <50.00%> (-5.52%)`	⬇️
packages/generator/src/generator.js	`86.22% <62.50%> (+0.93%)`	⬆️
packages/cli/src/utils/serve.js	`72.41% <72.41%> (ø)`
... and 11 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 57773c9...072d7c7. Read the comment docs.

packages/webpack/src/config/base.js

pi0 · 2020-07-27T13:36:40Z

@farnabaz Would be nice also adding to the docs

option was introduced ins nuxt/nuxt#7785

The option introduced in nuxt/nuxt#7785

* docs: add corejs option to configuration build docs The option introduced in nuxt/nuxt#7785 * Update configuration-build.md Co-authored-by: Sébastien Chopin <seb@nuxtjs.com>

rchl · 2020-07-27T17:31:36Z

a) I don't see types being updated
b) It seems like the code is assigning strings rather than numbers to corejs.version. Won't this be a problem for babel-preset-env?

rchl · 2020-07-27T17:32:55Z

packages/webpack/src/config/base.js

+      }
+    }
+
+    if (corejsVersion !== '2' && corejsVersion !== '3') {


Comparing with strings but user is supposed to provide 2 or 3 as numbers?

* fix: positions to old docs * fix(pages): handle redirect in mounted * chore(deps): update dependencies * chore(nuxt): remove components plugin * chore(nuxt): comment http proxy * chore(content): clean * chore(components): move to global * chore(pages): remove log * fix(content): put AppSearchInput component html in quotes * fix(pages): improve fallback * fix(components): nav links color * fix: positions * fix(pages): sortBy guides deep * fix: routes position * fix: positions * adding fr translation for installations guides (#387) * chore(deps): use nuxt-static * fix: links and env * chore(deps): update lock * fix(plugins): use nuxtLocale from runtimeConfig * fix(pages): remove double slash on contributors-api call * feat: add toc to top instead of right * feat: fallback component * chore(deps): update lock for @nuxt/content * fix(pages): update sortBy position * feat: add images * feat: chinese * feat: russian * feat: korean translations * feat: japanese translations * feat: indonesian translations * feat: ssr releases * fix: remove non tranlatable texts * fix: remove non tranlatable texts * fix: remove lodash fix version * fix: clean store * fix: lodash package performance * feat: indonesian docs categories * fix: remove toc from old docs * feat: japanese categories * feat: chinese categories * feat: chinese categories * feat: file names to code blocks * feat: russion categories * feat: korean categories * fix: update pwa module * feat: add lazy loading * feat: add lazy loading * fix(components): improve navigation * chore(components): improve code-group design * feat: add prettier * feat: add prettier * fix(components): update code-group * fix: algolia search * fix: remove prev next old docs * feat: fixes and texts added * fix: add exmaples to content page * feat: release notes link and upgrading * fix: no need to fetch releases on build * chore: improvements * feat: live preview page * chore: upgrade to latest http * fix: texts * fix: minor fixes from ambassador feedback * fix: color and broken links * fix: minor fixes * fix: remove contribute from release notes * add chevron to headings * fix: remove export * fix: update alerts * fix: add alerts * fix: alerts and links * feat: add copy to blog * fix(nuxt): put back NUXT_LOCALE * chore(pages): use defaultLocale for menu and surround of guides * feat: readme and env locale * chore(pages): display only defaultLocale for guides in production * feat: update readme * fix: typos and link errors * fix: update readMe * First configuration i18n Spanish version (#390) Co-authored-by: albasilventefuentes <alba@square1.io> * fix: update readme * feat: add cypress first tests * feat: linters for cypress * feat: prettier and cypress * fix: eslint errors * fix: cypress ci * fix: cypress ci * fix: cypress ci start * fix: cypress ci start * fix: cypress ci * fix: cypress ci * test: test the tests * fix(css): update copy button style * test: test netlify doesn't build * test: skip broken test * test: fix broken tests so it builds * fix: fix build * fix: test serve for Netlify / Cypress * fix: github actions * fix: fix build * test: test build * test: add cypress install to test command * test: add install cyptess to generate command * feat: modal for images * fix: add code for * fix: text fixes * feat: add button to next book * fix: remove spanish version for now * test: add test for modal * lint: no console rule * test: add test for prev next * tests: test the toc * fix: add force to cypress install to fix build * test: testing build * test: testing build * test: activate toc test * fix: fix tests * tests: add modal test * test: add to toc test * fix: remove url from toc test * fix: tests remove iframe * test: testing workflow for build * fix: add route to test * test: modify modal test to not be multiple * test: skip modal test to test build * test: add one modal back in * test: test image modal test * test: remove first * test: skip modals so build works * test: netlify build plugin * test: add modal test to test netlify plugin * test: skip modal test * test: test memory size for netlify build * test: add basic test * test: testing the modal simple test * test: add describe block test modal * test: modal and home * test: fix modal tests * test: modal test use within * test: test modal * test: separate modals to test build * test: skip image modal test * test: skip modal image test * test: remove Cypress.config().baseUrl * chore: improvements on aside * feat: release notes redirect * fix: remove old release page * docs: remove nuxt export for smarter nuxt generate * docs: use alert for next step and improve data fetching * chore: upgrade to latest nuxt * chore: remove eslintcache from git * fix: remove hooks chapter * fix: release notes fix * fix: add base next * fix: links to guides * docs: add router.prefetchPaylods option * fix: fix broken link * fix test script and remove old scripts * fix: fix github action * docs: add info for generate.cache * feat: add toc to sidebar * fix: full with home page on mobile * fix: add static example to upgrading * fix: add star icon * fix: gitignore warn and headings changed * fix: reorder page and headings * fix: add menu instead of title to prev and next * fix: add toc to mobile * fix: lint staged * lint: changes to lint staged * lint: test linters * lint: lint fixes * lint: prettier rule * fix: add filename to blogs * lint: test lint rules * lint: lint rules for precommit * lint: lint rules for precommit * lint: lint rules for precommit * lint: test linter * lint: test linters * lint: testi linter rules * lint: test linter * lint: test linters * lint: testing linters * lint: fix stylelint errors * fix(renderingModes): highlight full mode code line (#393) * chore(deploymentTargets): move hint to static (#394) * fix(home): title is shown twice (#395) * fix(home): title is shown twice * Update HomeWelcome.vue * Update HomeWelcome.vue * feat: add team page * fix: team member * lint: reduce linter rules * fix: i18n interpolation * feat: interpolation for i18n * feat: title component * fix: modify title * lint: remove lint rule * feat: interpolation for translations * fix: change core to nuxt team add link ambassadors * fix: remove uppercase for consistency * fix: remove old packages * fix: translationand route fixes * context diagram updated - added config object (#396) * context diagram updated - added object * Nuxt version updated from 2.13 to 2.14 on context diagram * feat: add copy svg instead of text * docs: addition to azure deploy * fix: update team websites and twitter accounts (#401) * fix: roles in team page * fix: nuxt word fix * blog: add new post with graph * fix: graph * feat: improvements to graph * fix: add more authors to post * fix: copy button remove svg * feat: add blog image * fix twitter link * feat: add new bar chart with vue-chart * feat: add more tags * blog: update article * blog: add last block * docs: set to 2.14 * docs: add docs link to article * docs: add links to projects * feat: team page * fix: spacing on team page * team: add maintainer * docs(blog): fix typo (#405) * chore: use official country name (#406) * chore: improvements * docs: add corejs option to configuration build docs (#404) * docs: add corejs option to configuration build docs The option introduced in nuxt/nuxt#7785 * Update configuration-build.md Co-authored-by: Sébastien Chopin <seb@nuxtjs.com> * docs: add corejs to new guides * team: update team member Co-authored-by: debs-obrien <debs_obrien@yahoo.co.uk> Co-authored-by: Benjamin Canac <canacb1@gmail.com> Co-authored-by: fgiraud <hello@florent.dev> Co-authored-by: Sergey Bedritsky <sergey.bedritsky@gmail.com> Co-authored-by: Alba Silvente Fuentes <36744484+Dawntraoz@users.noreply.github.com> Co-authored-by: albasilventefuentes <alba@square1.io> Co-authored-by: Alexander Lichter <manniL@gmx.net> Co-authored-by: Krutie Patel <krutie.patel@gmail.com> Co-authored-by: Daniel Roe <daniel@roe.dev> Co-authored-by: pooya parsa <pyapar@gmail.com> Co-authored-by: Pim <pimlie@hotmail.com> Co-authored-by: Ahad Birang <farnabaz@gmail.com>

pi0 · 2020-07-27T17:39:14Z

@rchl It is normalized and passed as a string src

Would be nice if can open a PR to support number and also add missing types :)

* fix: positions to old docs * fix(pages): handle redirect in mounted * chore(deps): update dependencies * chore(nuxt): remove components plugin * chore(nuxt): comment http proxy * chore(content): clean * chore(components): move to global * chore(pages): remove log * fix(content): put AppSearchInput component html in quotes * fix(pages): improve fallback * fix(components): nav links color * fix: positions * fix(pages): sortBy guides deep * fix: routes position * fix: positions * adding fr translation for installations guides (#387) * chore(deps): use nuxt-static * fix: links and env * chore(deps): update lock * fix(plugins): use nuxtLocale from runtimeConfig * fix(pages): remove double slash on contributors-api call * feat: add toc to top instead of right * feat: fallback component * chore(deps): update lock for @nuxt/content * fix(pages): update sortBy position * feat: add images * feat: chinese * feat: russian * feat: korean translations * feat: japanese translations * feat: indonesian translations * feat: ssr releases * fix: remove non tranlatable texts * fix: remove non tranlatable texts * fix: remove lodash fix version * fix: clean store * fix: lodash package performance * feat: indonesian docs categories * fix: remove toc from old docs * feat: japanese categories * feat: chinese categories * feat: chinese categories * feat: file names to code blocks * feat: russion categories * feat: korean categories * fix: update pwa module * feat: add lazy loading * feat: add lazy loading * fix(components): improve navigation * chore(components): improve code-group design * feat: add prettier * feat: add prettier * fix(components): update code-group * fix: algolia search * fix: remove prev next old docs * feat: fixes and texts added * fix: add exmaples to content page * feat: release notes link and upgrading * fix: no need to fetch releases on build * chore: improvements * feat: live preview page * chore: upgrade to latest http * fix: texts * fix: minor fixes from ambassador feedback * fix: color and broken links * fix: minor fixes * fix: remove contribute from release notes * add chevron to headings * fix: remove export * fix: update alerts * fix: add alerts * fix: alerts and links * feat: add copy to blog * fix(nuxt): put back NUXT_LOCALE * chore(pages): use defaultLocale for menu and surround of guides * feat: readme and env locale * chore(pages): display only defaultLocale for guides in production * feat: update readme * fix: typos and link errors * fix: update readMe * First configuration i18n Spanish version (#390) Co-authored-by: albasilventefuentes <alba@square1.io> * fix: update readme * feat: add cypress first tests * feat: linters for cypress * feat: prettier and cypress * fix: eslint errors * fix: cypress ci * fix: cypress ci * fix: cypress ci start * fix: cypress ci start * fix: cypress ci * fix: cypress ci * test: test the tests * fix(css): update copy button style * test: test netlify doesn't build * test: skip broken test * test: fix broken tests so it builds * fix: fix build * fix: test serve for Netlify / Cypress * fix: github actions * fix: fix build * test: test build * test: add cypress install to test command * test: add install cyptess to generate command * feat: modal for images * fix: add code for * fix: text fixes * feat: add button to next book * fix: remove spanish version for now * test: add test for modal * lint: no console rule * test: add test for prev next * tests: test the toc * fix: add force to cypress install to fix build * test: testing build * test: testing build * test: activate toc test * fix: fix tests * tests: add modal test * test: add to toc test * fix: remove url from toc test * fix: tests remove iframe * test: testing workflow for build * fix: add route to test * test: modify modal test to not be multiple * test: skip modal test to test build * test: add one modal back in * test: test image modal test * test: remove first * test: skip modals so build works * test: netlify build plugin * test: add modal test to test netlify plugin * test: skip modal test * test: test memory size for netlify build * test: add basic test * test: testing the modal simple test * test: add describe block test modal * test: modal and home * test: fix modal tests * test: modal test use within * test: test modal * test: separate modals to test build * test: skip image modal test * test: skip modal image test * test: remove Cypress.config().baseUrl * chore: improvements on aside * feat: release notes redirect * fix: remove old release page * docs: remove nuxt export for smarter nuxt generate * docs: use alert for next step and improve data fetching * chore: upgrade to latest nuxt * chore: remove eslintcache from git * fix: remove hooks chapter * fix: release notes fix * fix: add base next * fix: links to guides * docs: add router.prefetchPaylods option * fix: fix broken link * fix test script and remove old scripts * fix: fix github action * docs: add info for generate.cache * feat: add toc to sidebar * fix: full with home page on mobile * fix: add static example to upgrading * fix: add star icon * fix: gitignore warn and headings changed * fix: reorder page and headings * fix: add menu instead of title to prev and next * fix: add toc to mobile * fix: lint staged * lint: changes to lint staged * lint: test linters * lint: lint fixes * lint: prettier rule * fix: add filename to blogs * lint: test lint rules * lint: lint rules for precommit * lint: lint rules for precommit * lint: lint rules for precommit * lint: test linter * lint: test linters * lint: testi linter rules * lint: test linter * lint: test linters * lint: testing linters * lint: fix stylelint errors * fix(renderingModes): highlight full mode code line (#393) * chore(deploymentTargets): move hint to static (#394) * fix(home): title is shown twice (#395) * fix(home): title is shown twice * Update HomeWelcome.vue * Update HomeWelcome.vue * feat: add team page * fix: team member * lint: reduce linter rules * fix: i18n interpolation * feat: interpolation for i18n * feat: title component * fix: modify title * lint: remove lint rule * feat: interpolation for translations * fix: change core to nuxt team add link ambassadors * fix: remove uppercase for consistency * fix: remove old packages * fix: translationand route fixes * context diagram updated - added config object (#396) * context diagram updated - added object * Nuxt version updated from 2.13 to 2.14 on context diagram * feat: add copy svg instead of text * docs: addition to azure deploy * fix: update team websites and twitter accounts (#401) * fix: roles in team page * fix: nuxt word fix * blog: add new post with graph * fix: graph * feat: improvements to graph * fix: add more authors to post * fix: copy button remove svg * feat: add blog image * fix twitter link * feat: add new bar chart with vue-chart * feat: add more tags * blog: update article * blog: add last block * docs: set to 2.14 * docs: add docs link to article * docs: add links to projects * feat: team page * fix: spacing on team page * team: add maintainer * docs(blog): fix typo (#405) * chore: use official country name (#406) * chore: improvements * docs: add corejs option to configuration build docs (#404) * docs: add corejs option to configuration build docs The option introduced in nuxt/nuxt#7785 * Update configuration-build.md Co-authored-by: Sébastien Chopin <seb@nuxtjs.com> * docs: add corejs to new guides * team: update team member Co-authored-by: debs-obrien <debs_obrien@yahoo.co.uk> Co-authored-by: Benjamin Canac <canacb1@gmail.com> Co-authored-by: fgiraud <hello@florent.dev> Co-authored-by: Sergey Bedritsky <sergey.bedritsky@gmail.com> Co-authored-by: Alba Silvente Fuentes <36744484+Dawntraoz@users.noreply.github.com> Co-authored-by: albasilventefuentes <alba@square1.io> Co-authored-by: Alexander Lichter <manniL@gmx.net> Co-authored-by: Krutie Patel <krutie.patel@gmail.com> Co-authored-by: Daniel Roe <daniel@roe.dev> Co-authored-by: pooya parsa <pyapar@gmail.com> Co-authored-by: Pim <pimlie@hotmail.com> Co-authored-by: Ahad Birang <farnabaz@gmail.com>

* fix: positions to old docs * fix(pages): handle redirect in mounted * chore(deps): update dependencies * chore(nuxt): remove components plugin * chore(nuxt): comment http proxy * chore(content): clean * chore(components): move to global * chore(pages): remove log * fix(content): put AppSearchInput component html in quotes * fix(pages): improve fallback * fix(components): nav links color * fix: positions * fix(pages): sortBy guides deep * fix: routes position * fix: positions * adding fr translation for installations guides (nuxt#387) * chore(deps): use nuxt-static * fix: links and env * chore(deps): update lock * fix(plugins): use nuxtLocale from runtimeConfig * fix(pages): remove double slash on contributors-api call * feat: add toc to top instead of right * feat: fallback component * chore(deps): update lock for @nuxt/content * fix(pages): update sortBy position * feat: add images * feat: chinese * feat: russian * feat: korean translations * feat: japanese translations * feat: indonesian translations * feat: ssr releases * fix: remove non tranlatable texts * fix: remove non tranlatable texts * fix: remove lodash fix version * fix: clean store * fix: lodash package performance * feat: indonesian docs categories * fix: remove toc from old docs * feat: japanese categories * feat: chinese categories * feat: chinese categories * feat: file names to code blocks * feat: russion categories * feat: korean categories * fix: update pwa module * feat: add lazy loading * feat: add lazy loading * fix(components): improve navigation * chore(components): improve code-group design * feat: add prettier * feat: add prettier * fix(components): update code-group * fix: algolia search * fix: remove prev next old docs * feat: fixes and texts added * fix: add exmaples to content page * feat: release notes link and upgrading * fix: no need to fetch releases on build * chore: improvements * feat: live preview page * chore: upgrade to latest http * fix: texts * fix: minor fixes from ambassador feedback * fix: color and broken links * fix: minor fixes * fix: remove contribute from release notes * add chevron to headings * fix: remove export * fix: update alerts * fix: add alerts * fix: alerts and links * feat: add copy to blog * fix(nuxt): put back NUXT_LOCALE * chore(pages): use defaultLocale for menu and surround of guides * feat: readme and env locale * chore(pages): display only defaultLocale for guides in production * feat: update readme * fix: typos and link errors * fix: update readMe * First configuration i18n Spanish version (nuxt#390) Co-authored-by: albasilventefuentes <alba@square1.io> * fix: update readme * feat: add cypress first tests * feat: linters for cypress * feat: prettier and cypress * fix: eslint errors * fix: cypress ci * fix: cypress ci * fix: cypress ci start * fix: cypress ci start * fix: cypress ci * fix: cypress ci * test: test the tests * fix(css): update copy button style * test: test netlify doesn't build * test: skip broken test * test: fix broken tests so it builds * fix: fix build * fix: test serve for Netlify / Cypress * fix: github actions * fix: fix build * test: test build * test: add cypress install to test command * test: add install cyptess to generate command * feat: modal for images * fix: add code for * fix: text fixes * feat: add button to next book * fix: remove spanish version for now * test: add test for modal * lint: no console rule * test: add test for prev next * tests: test the toc * fix: add force to cypress install to fix build * test: testing build * test: testing build * test: activate toc test * fix: fix tests * tests: add modal test * test: add to toc test * fix: remove url from toc test * fix: tests remove iframe * test: testing workflow for build * fix: add route to test * test: modify modal test to not be multiple * test: skip modal test to test build * test: add one modal back in * test: test image modal test * test: remove first * test: skip modals so build works * test: netlify build plugin * test: add modal test to test netlify plugin * test: skip modal test * test: test memory size for netlify build * test: add basic test * test: testing the modal simple test * test: add describe block test modal * test: modal and home * test: fix modal tests * test: modal test use within * test: test modal * test: separate modals to test build * test: skip image modal test * test: skip modal image test * test: remove Cypress.config().baseUrl * chore: improvements on aside * feat: release notes redirect * fix: remove old release page * docs: remove nuxt export for smarter nuxt generate * docs: use alert for next step and improve data fetching * chore: upgrade to latest nuxt * chore: remove eslintcache from git * fix: remove hooks chapter * fix: release notes fix * fix: add base next * fix: links to guides * docs: add router.prefetchPaylods option * fix: fix broken link * fix test script and remove old scripts * fix: fix github action * docs: add info for generate.cache * feat: add toc to sidebar * fix: full with home page on mobile * fix: add static example to upgrading * fix: add star icon * fix: gitignore warn and headings changed * fix: reorder page and headings * fix: add menu instead of title to prev and next * fix: add toc to mobile * fix: lint staged * lint: changes to lint staged * lint: test linters * lint: lint fixes * lint: prettier rule * fix: add filename to blogs * lint: test lint rules * lint: lint rules for precommit * lint: lint rules for precommit * lint: lint rules for precommit * lint: test linter * lint: test linters * lint: testi linter rules * lint: test linter * lint: test linters * lint: testing linters * lint: fix stylelint errors * fix(renderingModes): highlight full mode code line (nuxt#393) * chore(deploymentTargets): move hint to static (nuxt#394) * fix(home): title is shown twice (nuxt#395) * fix(home): title is shown twice * Update HomeWelcome.vue * Update HomeWelcome.vue * feat: add team page * fix: team member * lint: reduce linter rules * fix: i18n interpolation * feat: interpolation for i18n * feat: title component * fix: modify title * lint: remove lint rule * feat: interpolation for translations * fix: change core to nuxt team add link ambassadors * fix: remove uppercase for consistency * fix: remove old packages * fix: translationand route fixes * context diagram updated - added config object (nuxt#396) * context diagram updated - added object * Nuxt version updated from 2.13 to 2.14 on context diagram * feat: add copy svg instead of text * docs: addition to azure deploy * fix: update team websites and twitter accounts (nuxt#401) * fix: roles in team page * fix: nuxt word fix * blog: add new post with graph * fix: graph * feat: improvements to graph * fix: add more authors to post * fix: copy button remove svg * feat: add blog image * fix twitter link * feat: add new bar chart with vue-chart * feat: add more tags * blog: update article * blog: add last block * docs: set to 2.14 * docs: add docs link to article * docs: add links to projects * feat: team page * fix: spacing on team page * team: add maintainer * docs(blog): fix typo (nuxt#405) * chore: use official country name (nuxt#406) * chore: improvements * docs: add corejs option to configuration build docs (nuxt#404) * docs: add corejs option to configuration build docs The option introduced in nuxt/nuxt#7785 * Update configuration-build.md Co-authored-by: Sébastien Chopin <seb@nuxtjs.com> * docs: add corejs to new guides * team: update team member Co-authored-by: debs-obrien <debs_obrien@yahoo.co.uk> Co-authored-by: Benjamin Canac <canacb1@gmail.com> Co-authored-by: fgiraud <hello@florent.dev> Co-authored-by: Sergey Bedritsky <sergey.bedritsky@gmail.com> Co-authored-by: Alba Silvente Fuentes <36744484+Dawntraoz@users.noreply.github.com> Co-authored-by: albasilventefuentes <alba@square1.io> Co-authored-by: Alexander Lichter <manniL@gmx.net> Co-authored-by: Krutie Patel <krutie.patel@gmail.com> Co-authored-by: Daniel Roe <daniel@roe.dev> Co-authored-by: pooya parsa <pyapar@gmail.com> Co-authored-by: Pim <pimlie@hotmail.com> Co-authored-by: Ahad Birang <farnabaz@gmail.com>

* fix: positions to old docs * fix(pages): handle redirect in mounted * chore(deps): update dependencies * chore(nuxt): remove components plugin * chore(nuxt): comment http proxy * chore(content): clean * chore(components): move to global * chore(pages): remove log * fix(content): put AppSearchInput component html in quotes * fix(pages): improve fallback * fix(components): nav links color * fix: positions * fix(pages): sortBy guides deep * fix: routes position * fix: positions * adding fr translation for installations guides (#387) * chore(deps): use nuxt-static * fix: links and env * chore(deps): update lock * fix(plugins): use nuxtLocale from runtimeConfig * fix(pages): remove double slash on contributors-api call * feat: add toc to top instead of right * feat: fallback component * chore(deps): update lock for @nuxt/content * fix(pages): update sortBy position * feat: add images * feat: chinese * feat: russian * feat: korean translations * feat: japanese translations * feat: indonesian translations * feat: ssr releases * fix: remove non tranlatable texts * fix: remove non tranlatable texts * fix: remove lodash fix version * fix: clean store * fix: lodash package performance * feat: indonesian docs categories * fix: remove toc from old docs * feat: japanese categories * feat: chinese categories * feat: chinese categories * feat: file names to code blocks * feat: russion categories * feat: korean categories * fix: update pwa module * feat: add lazy loading * feat: add lazy loading * fix(components): improve navigation * chore(components): improve code-group design * feat: add prettier * feat: add prettier * fix(components): update code-group * fix: algolia search * fix: remove prev next old docs * feat: fixes and texts added * fix: add exmaples to content page * feat: release notes link and upgrading * fix: no need to fetch releases on build * chore: improvements * feat: live preview page * chore: upgrade to latest http * fix: texts * fix: minor fixes from ambassador feedback * fix: color and broken links * fix: minor fixes * fix: remove contribute from release notes * add chevron to headings * fix: remove export * fix: update alerts * fix: add alerts * fix: alerts and links * feat: add copy to blog * fix(nuxt): put back NUXT_LOCALE * chore(pages): use defaultLocale for menu and surround of guides * feat: readme and env locale * chore(pages): display only defaultLocale for guides in production * feat: update readme * fix: typos and link errors * fix: update readMe * First configuration i18n Spanish version (#390) Co-authored-by: albasilventefuentes <alba@square1.io> * fix: update readme * feat: add cypress first tests * feat: linters for cypress * feat: prettier and cypress * fix: eslint errors * fix: cypress ci * fix: cypress ci * fix: cypress ci start * fix: cypress ci start * fix: cypress ci * fix: cypress ci * test: test the tests * fix(css): update copy button style * test: test netlify doesn't build * test: skip broken test * test: fix broken tests so it builds * fix: fix build * fix: test serve for Netlify / Cypress * fix: github actions * fix: fix build * test: test build * test: add cypress install to test command * test: add install cyptess to generate command * feat: modal for images * fix: add code for * fix: text fixes * feat: add button to next book * fix: remove spanish version for now * test: add test for modal * lint: no console rule * test: add test for prev next * tests: test the toc * fix: add force to cypress install to fix build * test: testing build * test: testing build * test: activate toc test * fix: fix tests * tests: add modal test * test: add to toc test * fix: remove url from toc test * fix: tests remove iframe * test: testing workflow for build * fix: add route to test * test: modify modal test to not be multiple * test: skip modal test to test build * test: add one modal back in * test: test image modal test * test: remove first * test: skip modals so build works * test: netlify build plugin * test: add modal test to test netlify plugin * test: skip modal test * test: test memory size for netlify build * test: add basic test * test: testing the modal simple test * test: add describe block test modal * test: modal and home * test: fix modal tests * test: modal test use within * test: test modal * test: separate modals to test build * test: skip image modal test * test: skip modal image test * test: remove Cypress.config().baseUrl * chore: improvements on aside * feat: release notes redirect * fix: remove old release page * docs: remove nuxt export for smarter nuxt generate * docs: use alert for next step and improve data fetching * chore: upgrade to latest nuxt * chore: remove eslintcache from git * fix: remove hooks chapter * fix: release notes fix * fix: add base next * fix: links to guides * docs: add router.prefetchPaylods option * fix: fix broken link * fix test script and remove old scripts * fix: fix github action * docs: add info for generate.cache * feat: add toc to sidebar * fix: full with home page on mobile * fix: add static example to upgrading * fix: add star icon * fix: gitignore warn and headings changed * fix: reorder page and headings * fix: add menu instead of title to prev and next * fix: add toc to mobile * fix: lint staged * lint: changes to lint staged * lint: test linters * lint: lint fixes * lint: prettier rule * fix: add filename to blogs * lint: test lint rules * lint: lint rules for precommit * lint: lint rules for precommit * lint: lint rules for precommit * lint: test linter * lint: test linters * lint: testi linter rules * lint: test linter * lint: test linters * lint: testing linters * lint: fix stylelint errors * fix(renderingModes): highlight full mode code line (#393) * chore(deploymentTargets): move hint to static (#394) * fix(home): title is shown twice (#395) * fix(home): title is shown twice * Update HomeWelcome.vue * Update HomeWelcome.vue * feat: add team page * fix: team member * lint: reduce linter rules * fix: i18n interpolation * feat: interpolation for i18n * feat: title component * fix: modify title * lint: remove lint rule * feat: interpolation for translations * fix: change core to nuxt team add link ambassadors * fix: remove uppercase for consistency * fix: remove old packages * fix: translationand route fixes * context diagram updated - added config object (#396) * context diagram updated - added object * Nuxt version updated from 2.13 to 2.14 on context diagram * feat: add copy svg instead of text * docs: addition to azure deploy * fix: update team websites and twitter accounts (#401) * fix: roles in team page * fix: nuxt word fix * blog: add new post with graph * fix: graph * feat: improvements to graph * fix: add more authors to post * fix: copy button remove svg * feat: add blog image * fix twitter link * feat: add new bar chart with vue-chart * feat: add more tags * blog: update article * blog: add last block * docs: set to 2.14 * docs: add docs link to article * docs: add links to projects * feat: team page * fix: spacing on team page * team: add maintainer * docs(blog): fix typo (#405) * chore: use official country name (#406) * chore: improvements * docs: add corejs option to configuration build docs (#404) * docs: add corejs option to configuration build docs The option introduced in nuxt/nuxt#7785 * Update configuration-build.md Co-authored-by: Sébastien Chopin <seb@nuxtjs.com> * docs: add corejs to new guides * team: update team member Co-authored-by: debs-obrien <debs_obrien@yahoo.co.uk> Co-authored-by: Benjamin Canac <canacb1@gmail.com> Co-authored-by: fgiraud <hello@florent.dev> Co-authored-by: Sergey Bedritsky <sergey.bedritsky@gmail.com> Co-authored-by: Alba Silvente Fuentes <36744484+Dawntraoz@users.noreply.github.com> Co-authored-by: albasilventefuentes <alba@square1.io> Co-authored-by: Alexander Lichter <manniL@gmx.net> Co-authored-by: Krutie Patel <krutie.patel@gmail.com> Co-authored-by: Daniel Roe <daniel@roe.dev> Co-authored-by: pooya parsa <pyapar@gmail.com> Co-authored-by: Pim <pimlie@hotmail.com> Co-authored-by: Ahad Birang <farnabaz@gmail.com>

feat: add build option to set corejs version

b4f2759

farnabaz requested a review from pi0 July 27, 2020 10:34

pi0 reviewed Jul 27, 2020

View reviewed changes

packages/webpack/src/config/base.js Outdated Show resolved Hide resolved

pi0 reviewed Jul 27, 2020

View reviewed changes

packages/webpack/src/config/base.js Outdated Show resolved Hide resolved

clarkdo previously approved these changes Jul 27, 2020

View reviewed changes

fix tests

da78b4a

farnabaz dismissed clarkdo’s stale review via da78b4a July 27, 2020 12:20

pi0 reviewed Jul 27, 2020

View reviewed changes

packages/webpack/src/config/base.js Outdated Show resolved Hide resolved

pi0 changed the title ~~feat: add build option to set corejs version~~ feat(webpack): auto detect project core-js version Jul 27, 2020

pi0 changed the title ~~feat(webpack): auto detect project core-js version~~ feat(webpack): auto detect core-js version Jul 27, 2020

pi0 added 2 commits July 27, 2020 15:02

refactor: improve error handling and warn for invalid corejs version

4424e9c

fix: only pick major part

4804a94

pi0 force-pushed the corejs-version branch from 8ea0c3b to 4804a94 Compare July 27, 2020 13:11

simplify as we are already using try/catch

072d7c7

pi0 approved these changes Jul 27, 2020

View reviewed changes

pi0 merged commit 6a2576b into dev Jul 27, 2020

pi0 deleted the corejs-version branch July 27, 2020 13:38

farnabaz added a commit to farnabaz/docs that referenced this pull request Jul 27, 2020

add corejs option to configuration doc

46bc47a

option was introduced ins nuxt/nuxt#7785

farnabaz mentioned this pull request Jul 27, 2020

add corejs option to configuration doc nuxt/docs#2125

Closed

farnabaz added a commit to farnabaz/nuxtjs.org that referenced this pull request Jul 27, 2020

docs: add corejs option to configuration build docs

8884b23

The option introduced in nuxt/nuxt#7785

farnabaz mentioned this pull request Jul 27, 2020

docs: add corejs option to configuration build docs nuxt/website-v2#404

Merged

pi0 mentioned this pull request Jul 27, 2020

v2.14.0 #7691

Merged

rchl reviewed Jul 27, 2020

View reviewed changes

rchl mentioned this pull request Jul 27, 2020

fix: add types for build.corejs option and use number #7789

Merged

7 tasks

This was referenced Jul 29, 2020

docs: add setup details for using with core-js@3 nuxt-modules/storybook#18

Merged

Template doesn't compile nuxt-community/module-template#51

Closed

mcdmaster mentioned this pull request Aug 9, 2020

更新負荷低減のために未使用ライブラリを整理する Tokyo-Metro-Gov/covid19#5237

Closed

danielroe added the 2.x label Jan 18, 2023

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

feat(webpack): auto detect core-js version #7785

feat(webpack): auto detect core-js version #7785

farnabaz commented Jul 27, 2020 •

edited

codecov-commenter commented Jul 27, 2020 •

edited

pi0 commented Jul 27, 2020

rchl commented Jul 27, 2020

rchl Jul 27, 2020

pi0 commented Jul 27, 2020

feat(webpack): auto detect core-js version #7785

feat(webpack): auto detect core-js version #7785

Conversation

farnabaz commented Jul 27, 2020 • edited

Types of changes

Description

Checklist:

codecov-commenter commented Jul 27, 2020 • edited

Codecov Report

pi0 commented Jul 27, 2020

rchl commented Jul 27, 2020

rchl Jul 27, 2020

Choose a reason for hiding this comment

pi0 commented Jul 27, 2020

farnabaz commented Jul 27, 2020 •

edited

codecov-commenter commented Jul 27, 2020 •

edited