types: add missing loadingScreen type definition
#8648
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pi0
reviewed
Jan 14, 2021
pi0
changed the title
loadingScreen type definition
pi0
changed the title
loadingScreen type definition loadingScreen type definition
Co-authored-by: pooya parsa <pyapar@gmail.com>
pi0
approved these changes
Jan 14, 2021
|
Thanks! |
|
Welcome; glad I could contribute something! |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Types of changes
Description
This PR adds the missing type definition for
loadingScreenas mentioned in #6272. The feature was implemented but that made type definition incompatible (if you decide to overwrite this setting).Checklist: