(generate) dont assume /index.html exists when copying to 200.html #1937
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks @pimlie :) I was planning to make this fix too |
clarkdo
reviewed
Oct 25, 2017
| if (!existsSync(_200Path)) { | ||
| await copy(join(this.distPath, 'index.html'), _200Path) | ||
| const indexPath = join(this.distPath, 'index.html') | ||
| if (existsSync(indexPath) { |
There was a problem hiding this comment.
no idea how i missed that, same issue is in nuxt-generate-cluster and I worked on that all yesterday evening without noticing 😕
i will go stand in the corner
There was a problem hiding this comment.
Don't worry, CI can help us to find out it 😸 .
|
This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It may be an edge-case but users might not have a
/index.htmlin their project. So only copy it to200.htmlif an index file exists.