fix(types): don't pin webpack types to exact version

[rchl]

🔗 Linked issue

❓ Type of change

• 📖 Documentation (updates to the documentation, readme or JSdoc annotations)
• 🐞 Bug fix (a non-breaking change that fixes an issue)
• 👌 Enhancement (improving an existing functionality like performance)
• ✨ New feature (a non-breaking change that adds functionality)
• 🧹 Chore (updates to the build process or auxiliary tools and libraries)
• ⚠️ Breaking change (fix or feature that would cause existing functionality to change)

📚 Description

Since the current convention in @nuxt/types is to pin all dependencies to exact versions, I'm pretty sure this is not an acceptable solution but I wanted to raise an issue with the current approach.

The @types/webpack is pinned to 4.41.33. Since 4.41.34 is now the latest version, if I do yarn upgrade in my project, this will introduce both 4.41.33 and 4.41.34 and then the shim that extends webpack from @nuxt/types/shims.d.ts will stop working. A code like:

import '@nuxt/types'
import { MultiStats, AssetInfo } from 'webpack'

should show that MultiStats that the shim is supposed to introduce is not present.

It works if only 4.41.33 is installed in the project.

I'm not sure what to do with this problem. Clearly there was a reason for going with exact versions but as evident here, this is also not a good solution. Ideally a range should be allowed and as long as packages follow semver, it should not cause issues (but clearly did in the past).

@danielroe

📝 Checklist

• I have linked an issue or discussion.
• I have updated the documentation accordingly.

[stackblitz]

Run & review this pull request in StackBlitz Codeflow.

[codecov-commenter]

Codecov Report

All modified lines are covered by tests ✅

Comparison is base (6132947) 66.13% compared to head (4357799) 66.13%.

Additional details and impacted files

@@           Coverage Diff           @@
##              2.x   #23531   +/-   ##
=======================================
  Coverage   66.13%   66.13%           
=======================================
  Files          93       93           
  Lines        4125     4125           
  Branches     1171     1171           
=======================================
  Hits         2728     2728           
  Misses       1130     1130           
  Partials      267      267           

Flag	Coverage Δ
unittests	66.13% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[rchl]

CI here also started failing because of that issue.

[danielroe]

Maybe?

Suggested change

	"@types/webpack": "^4.41.33",
	"@types/webpack": "~4.41.33",

[rchl]

Should be fine for now if you prefer that but could cause a similar issue in the future.

For reference, there seemed to be an issue with @types/webpack-hot-middleware before that broke types in a patch release (#18827) but I'm not aware of there being any issues with @types/webpack.

[rchl]

@danielroe so would you prefer to use ~? I'm a bit skeptical because then it's guaranteed to break once webpack types update the minor version. I'd rather trust and hope that they don't break types in minor revision.