Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(types): don't pin webpack types to exact version #23531

Merged
merged 2 commits into from Oct 10, 2023
Merged

fix(types): don't pin webpack types to exact version #23531

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
a589a69
fix(types): don't pin webpack types to exact version
rchl Oct 4, 2023
4357799
update lock file
rchl Oct 4, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
2 changes: 1 addition & 1 deletion packages/types/package.json
View file
Open in desktop
Expand Up @@ -23,7 +23,7 @@
"@types/pug": "2.0.6",
"@types/serve-static": "1.15.2",
"@types/terser-webpack-plugin": "4.2.1",
"@types/webpack": "4.41.33",
"@types/webpack": "^4.41.33",
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe?

Suggested change
"@types/webpack": "^4.41.33",
"@types/webpack": "~4.41.33",

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should be fine for now if you prefer that but could cause a similar issue in the future.

For reference, there seemed to be an issue with @types/webpack-hot-middleware before that broke types in a patch release (#18827) but I'm not aware of there being any issues with @types/webpack.

Copy link
Author

@rchl rchl Oct 10, 2023 •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@danielroe so would you prefer to use ~? I'm a bit skeptical because then it's guaranteed to break once webpack types update the minor version. I'd rather trust and hope that they don't break types in minor revision.

"@types/webpack-bundle-analyzer": "3.9.5",
"@types/webpack-hot-middleware": "2.25.5"
},
Expand Down
8 changes: 4 additions & 4 deletions yarn.lock
View file
Open in desktop
Expand Up @@ -2834,10 +2834,10 @@
"@types/source-list-map" "*"
source-map "^0.7.3"

"@types/webpack@4.41.33", "@types/webpack@^4", "@types/webpack@^4.41.8":
version "4.41.33"
resolved "https://registry.npmjs.org/@types/webpack/-/webpack-4.41.33.tgz#16164845a5be6a306bcbe554a8e67f9cac215ffc"
integrity sha512-PPajH64Ft2vWevkerISMtnZ8rTs4YmRbs+23c402J0INmxDKCrhZNvwZYtzx96gY2wAtXdrK1BS2fiC8MlLr3g==
"@types/webpack@^4", "@types/webpack@^4.41.33", "@types/webpack@^4.41.8":
version "4.41.34"
resolved "https://registry.npmjs.org/@types/webpack/-/webpack-4.41.34.tgz#8cf616be84b39c8fb26f9459d4470a5514df2477"
integrity sha512-CN2aOGrR3zbMc2v+cKqzaClYP1ldkpPOgtdNvgX+RmlWCSWxHxpzz6WSCVQZRkF8D60ROlkRzAoEpgjWQ+bd2g==
dependencies:
"@types/node" "*"
"@types/tapable" "^1"
Expand Down