-
-
Notifications
You must be signed in to change notification settings - Fork 4.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: make optimization and splitChunks configurable #3060
Conversation
Codecov Report
@@ Coverage Diff @@
## dev #3060 +/- ##
====================================
Coverage 100% 100%
====================================
Files 4 4
Lines 19 19
Branches 2 2
====================================
Hits 19 19 Continue to review full report at Codecov.
|
@@ -6,7 +6,8 @@ export default class Browser { | |||
this.browser = await puppeteer.launch( | |||
Object.assign( | |||
{ | |||
args: ['--no-sandbox', '--disable-setuid-sandbox'] | |||
args: ['--no-sandbox', '--disable-setuid-sandbox'], | |||
executablePath: process.env.PUPPETEER_EXECUTABLE_PATH |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Useful when locally debugging without the need to download puppeteer:
export PUPPETEER_SKIP_CHROMIUM_DOWNLOAD=1
yarn install
# For macOS
export PUPPETEER_EXECUTABLE_PATH="/Applications/Google Chrome.app/Contents/MacOS/Google Chrome"
We may also use this to speed up CI's setup stage by pre-downloading chrome...
NOTE: puppeteer/puppeteer#3071 |
Thanks @Clark 😁👌 |
This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
As a continuation to previous works on
splitPages
, this PR makes bothoptimization
(webpack 4 option) andsplitChunks
fully customizable.We can disable all splitting features using this option in
nuxt.config.js
:Other improvements with this PR
shouldPrefetch
is falsy by default to improve TTLresourcHints
are disabled for dev modeSPA Improvements
render.shouldPrefetch
andrender.shouldPreload
loadingIndicator
to improve TTL