Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: inject scrollBehavior in a more tolerant way #3560

Merged
merged 1 commit into from
Jul 20, 2018
Merged

Conversation

Justineo
Copy link

Currently we cannot define scrollBehavior like:

scrollBehavior () { // ← we can have space before the parenthesis
  // ...
}

Fixed this by using a RegExp to be more tolerant.

@Justineo
Copy link
Author

Oops had no idea why e2e tests failed, may need some help with it...

Copy link
Member

@clarkdo clarkdo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@clarkdo
Copy link
Member

clarkdo commented Jul 20, 2018

@Justineo Thanks, the error should be due to CircleCI outage.

@codecov-io
Copy link

Codecov Report

Merging #3560 into dev will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##              dev    #3560   +/-   ##
=======================================
  Coverage   99.19%   99.19%           
=======================================
  Files          18       18           
  Lines        1116     1116           
  Branches      300      300           
=======================================
  Hits         1107     1107           
  Misses          9        9

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update dfef525...3643833. Read the comment docs.

@clarkdo clarkdo merged commit b5f6ed1 into nuxt:dev Jul 20, 2018
@lock
Copy link

lock bot commented Nov 1, 2018

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@lock lock bot locked as resolved and limited conversation to collaborators Nov 1, 2018
@danielroe danielroe added the 2.x label Jan 18, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants