Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: test utils cleanup #4180

Merged
merged 14 commits into from
Oct 24, 2018
Merged

chore: test utils cleanup #4180

merged 14 commits into from
Oct 24, 2018

Conversation

galvez
Copy link

@galvez galvez commented Oct 24, 2018

Refactor test/utils to better separate Nuxt-specific imports/exports and generally clean up these files' headers. Also removed a comment mentioning a createSportsSelectionView which doesn't appear to be related to Nuxt at all.

@codecov-io
Copy link

codecov-io commented Oct 24, 2018

Codecov Report

Merging #4180 into dev will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@          Coverage Diff          @@
##             dev   #4180   +/-   ##
=====================================
  Coverage   81.8%   81.8%           
=====================================
  Files         29      29           
  Lines       1561    1561           
  Branches     409     409           
=====================================
  Hits        1277    1277           
  Misses       224     224           
  Partials      60      60

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e876ce6...9ee7d0d. Read the comment docs.

@galvez galvez self-assigned this Oct 24, 2018
export { default as Modes } from './modes'
export { default as NuxtConfig } from './nuxt.config'
export { default as Options } from './options'
export * from './utils'
export const Utils = _Utils
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Now we export an object Utils includes all functions in ./utils and also all functions on index, it looks kind of confusing, we'd better keep only one behaviour.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@clarkdo gotcha, makes sense. I'll modify.

@galvez
Copy link
Author

galvez commented Oct 24, 2018

@clarkdo updated, tests passing :)

pi0
pi0 previously approved these changes Oct 24, 2018
Copy link
Member

@pi0 pi0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@pi0 pi0 merged commit 5ec5cda into dev Oct 24, 2018
@pi0 pi0 deleted the test-utils-cleanup branch October 24, 2018 13:53
@lock
Copy link

lock bot commented Nov 23, 2018

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@lock lock bot locked as resolved and limited conversation to collaborators Nov 23, 2018
@danielroe danielroe added the 2.x label Jan 18, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants