-
-
Notifications
You must be signed in to change notification settings - Fork 5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: test utils cleanup #4180
Conversation
Codecov Report
@@ Coverage Diff @@
## dev #4180 +/- ##
=====================================
Coverage 81.8% 81.8%
=====================================
Files 29 29
Lines 1561 1561
Branches 409 409
=====================================
Hits 1277 1277
Misses 224 224
Partials 60 60 Continue to review full report at Codecov.
|
packages/common/src/index.js
Outdated
export { default as Modes } from './modes' | ||
export { default as NuxtConfig } from './nuxt.config' | ||
export { default as Options } from './options' | ||
export * from './utils' | ||
export const Utils = _Utils |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Now we export an object Utils
includes all functions in ./utils
and also all functions on index
, it looks kind of confusing, we'd better keep only one behaviour.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@clarkdo gotcha, makes sense. I'll modify.
@clarkdo updated, tests passing :) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
Refactor
test/utils
to better separate Nuxt-specific imports/exports and generally clean up these files' headers. Also removed a comment mentioning acreateSportsSelectionView
which doesn't appear to be related to Nuxt at all.