Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(modern): auto detect modern mode #4422

Merged
merged 3 commits into from
Nov 26, 2018
Merged

Conversation

clarkdo
Copy link
Member

@clarkdo clarkdo commented Nov 26, 2018

Types of changes

  • Bug fix (a non-breaking change which fixes an issue)
  • New feature (a non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Description

If user doesn't specify modern in command and nuxt.config.js, a middleware will detect by if there is modern built asset in dist:

  1. ssr: server
  2. spa: client
  3. no modern assets: false

Checklist:

  • My change requires a change to the documentation.
  • I have updated the documentation accordingly. (PR: #)
  • I have added tests to cover my changes (if not applicable, please state why)
  • All new and existing tests are passing.

@clarkdo clarkdo changed the title auto detect modern feat: auto defetct modern mode Nov 26, 2018
@clarkdo clarkdo requested a review from pi0 November 26, 2018 13:08
@codecov-io
Copy link

codecov-io commented Nov 26, 2018

Codecov Report

Merging #4422 into dev will increase coverage by 0.05%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff            @@
##              dev   #4422      +/-   ##
=========================================
+ Coverage   91.35%   91.4%   +0.05%     
=========================================
  Files          56      56              
  Lines        1931    1943      +12     
  Branches      483     485       +2     
=========================================
+ Hits         1764    1776      +12     
  Misses        155     155              
  Partials       12      12
Impacted Files Coverage Δ
packages/config/src/config/_common.js 100% <ø> (ø) ⬆️
packages/config/src/options.js 94.81% <ø> (-0.08%) ⬇️
packages/server/src/middleware/modern.js 100% <100%> (ø) ⬆️
packages/vue-renderer/src/renderer.js 100% <100%> (ø) ⬆️
packages/server/src/server.js 100% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8cc954d...de39503. Read the comment docs.

@pi0 pi0 changed the title feat: auto defetct modern mode feat: auto detect modern mode Nov 26, 2018
@pi0 pi0 changed the title feat: auto detect modern mode feat(modern): auto detect modern mode Nov 26, 2018
@clarkdo clarkdo merged commit fe492d8 into nuxt:dev Nov 26, 2018
@clarkdo
Copy link
Member Author

clarkdo commented Nov 30, 2018

Resolve #4356

@lock
Copy link

lock bot commented Dec 30, 2018

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@lock lock bot locked as resolved and limited conversation to collaborators Dec 30, 2018
@clarkdo clarkdo deleted the modern-detect branch April 2, 2019 13:10
@danielroe danielroe added the 2.x label Jan 18, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants