Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: keepAliveProps broken in <nuxt-child> #4521

Merged
merged 1 commit into from Dec 11, 2018
Merged

fix: keepAliveProps broken in <nuxt-child> #4521

merged 1 commit into from Dec 11, 2018

Conversation

ousiri
Copy link

@ousiri ousiri commented Dec 11, 2018

The keepAliveProps prop support is broken during 2.3.0 because the prop is not declared in .

Related doc: https://nuxtjs.org/api/components-nuxt-child
Related pr: #4067

Types of changes

  • Bug fix (a non-breaking change which fixes an issue)
  • New feature (a non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Description

Checklist:

  • My change requires a change to the documentation.
  • I have updated the documentation accordingly. (PR: #)
  • I have added tests to cover my changes (if not applicable, please state why)
  • All new and existing tests are passing.

@codecov-io
Copy link

codecov-io commented Dec 11, 2018

Codecov Report

Merging #4521 into dev will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##              dev    #4521   +/-   ##
=======================================
  Coverage   91.13%   91.13%           
=======================================
  Files          61       61           
  Lines        2188     2188           
  Branches      527      527           
=======================================
  Hits         1994     1994           
  Misses        176      176           
  Partials       18       18

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 51e4488...1f9850e. Read the comment docs.

Copy link
Member

@pi0 pi0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This PR may require cherry-picked into 2.x too

@Atinux Atinux merged commit 431cc15 into nuxt:dev Dec 11, 2018
@Atinux
Copy link
Member

Atinux commented Dec 11, 2018

Can you cherry pick it now @pi0 ?

Great work @ousiri

pi0 pushed a commit that referenced this pull request Dec 11, 2018
@lock
Copy link

lock bot commented Jan 10, 2019

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@lock lock bot locked as resolved and limited conversation to collaborators Jan 10, 2019
@danielroe danielroe added the 2.x label Jan 18, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants