Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: .nuxtignore #4647

Merged
merged 35 commits into from Jan 29, 2019
Merged

feat: .nuxtignore #4647

merged 35 commits into from Jan 29, 2019

Conversation

clarkdo
Copy link
Member

@clarkdo clarkdo commented Dec 28, 2018

Types of changes

  • New feature (a non-breaking change which adds functionality)

Description

First prototype of ignore features.
Related: nuxt/rfcs#21

  • deprecate current ignore and ignorePrefix (Maybe in 3.0 ?), then support node-glob-gitignore
  • same rules as .gitignore/.eslintignore
  • support .nuxtignore file under srcDir
  • support ignore pages/layouts to be ignored
  • support store
  • support middleware
  • support plugin This is unnecessary since plugin is already bundled on demand
  • watch .nuxtignore in dev mode

Checklist:

  • My change requires a change to the documentation.
  • I have updated the documentation accordingly. (PR: #)
  • I have added tests to cover my changes (if not applicable, please state why)
  • All new and existing tests are passing.

@clarkdo clarkdo requested review from pi0 and Atinux December 28, 2018 16:18
@codecov-io
Copy link

codecov-io commented Dec 28, 2018

Codecov Report

Merging #4647 into dev will decrease coverage by 0.12%.
The diff coverage is 90%.

Impacted file tree graph

@@            Coverage Diff             @@
##              dev    #4647      +/-   ##
==========================================
- Coverage   91.39%   91.27%   -0.13%     
==========================================
  Files          71       72       +1     
  Lines        2360     2395      +35     
  Branches      583      592       +9     
==========================================
+ Hits         2157     2186      +29     
- Misses        185      191       +6     
  Partials       18       18
Impacted Files Coverage Δ
packages/builder/src/ignore.js 85% <85%> (ø)
packages/builder/src/builder.js 89.95% <95%> (+0.22%) ⬆️
packages/vue-renderer/src/renderer.js 94.56% <0%> (-1.09%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a303ea8...3f2ab41. Read the comment docs.

@ricardogobbosouza
Copy link
Contributor

Hi @clarkdo
Could not you use this to bypass the other files in directories assets, components , middleware, plugins, static, store ?

@clarkdo
Copy link
Member Author

clarkdo commented Dec 31, 2018

@ricardogobbosouza Thanks for the reviewing, the features you mentioned are already on the plan, we'll finish them step by step.

@clarkdo clarkdo self-assigned this Dec 31, 2018
@clarkdo clarkdo added the WIP label Dec 31, 2018
@ricardogobbosouza
Copy link
Contributor

@clarkdo What do you think of moving packages/builder/src/ignore.js to @nuxtjs/utils ?

@clarkdo
Copy link
Member Author

clarkdo commented Jan 2, 2019

@ricardogobbosouza It should be, thanks.

@clarkdo clarkdo changed the title feat: .nuxtignore in pages and layouts feat: .nuxtignore Jan 2, 2019
@clarkdo clarkdo removed request for Atinux and pi0 January 2, 2019 14:04
packages/builder/src/builder.js Outdated Show resolved Hide resolved
packages/builder/src/builder.js Outdated Show resolved Hide resolved
packages/utils/src/ignore.js Outdated Show resolved Hide resolved
packages/builder/src/builder.js Outdated Show resolved Hide resolved
packages/vue-app/template/store.js Outdated Show resolved Hide resolved
packages/vue-app/template/store.js Outdated Show resolved Hide resolved
@clarkdo clarkdo removed the WIP label Jan 23, 2019
@clarkdo clarkdo requested review from Atinux and pi0 January 23, 2019 18:50
packages/builder/src/builder.js Show resolved Hide resolved
packages/builder/src/builder.js Show resolved Hide resolved
@clarkdo clarkdo merged commit 59be77a into nuxt:dev Jan 29, 2019
@manniL
Copy link
Member

manniL commented Jan 29, 2019

@clarkdo Is there a doc PR present?

@clarkdo
Copy link
Member Author

clarkdo commented Jan 29, 2019

@manniL Working on it

@manniL
Copy link
Member

manniL commented Feb 12, 2019

@clarkdo Should we deprecate ignore / ignorePrefix in 2.x? 🤔

@clarkdo
Copy link
Member Author

clarkdo commented Feb 12, 2019

@manniL As discussed before, it would be better to deprecate it in 3.0

@pi0 pi0 mentioned this pull request Mar 14, 2019
@clarkdo clarkdo deleted the feat/nuxtignore branch April 2, 2019 13:19
@danielroe danielroe added the 2.x label Jan 18, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

7 participants