Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: relax lock settings #5280

Merged
merged 1 commit into from
Mar 19, 2019
Merged

fix: relax lock settings #5280

merged 1 commit into from
Mar 19, 2019

Conversation

pimlie
Copy link

@pimlie pimlie commented Mar 19, 2019

Types of changes

  • Bug fix (a non-breaking change which fixes an issue)
  • New feature (a non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Description

Relaxing the lock settings a bit should make it less likely the lock gets compromised due to cpu/io starvation.

  • compromised lock is a warning now, not a fatal error
  • stale timeout is twice as high, 30s now

Checklist:

  • My change requires a change to the documentation.
  • I have updated the documentation accordingly. (PR: #)
  • I have added tests to cover my changes (if not applicable, please state why)
  • All new and existing tests are passing.

@codecov-io
Copy link

codecov-io commented Mar 19, 2019

Codecov Report

Merging #5280 into dev will not change coverage.
The diff coverage is 100%.

Impacted file tree graph

@@         Coverage Diff          @@
##            dev   #5280   +/-   ##
====================================
  Coverage    96%     96%           
====================================
  Files        74      74           
  Lines      2500    2500           
  Branches    635     635           
====================================
  Hits       2400    2400           
  Misses       84      84           
  Partials     16      16
Impacted Files Coverage Δ
packages/utils/src/locking.js 100% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2eb1965...5582ccb. Read the comment docs.

@atinux atinux self-requested a review March 19, 2019 13:54
@atinux atinux merged commit 65a431d into nuxt:dev Mar 19, 2019
@atinux
Copy link
Member

atinux commented Mar 19, 2019

❤️

@pi0 pi0 mentioned this pull request Mar 20, 2019
@pimlie pimlie deleted the fix-relax-locking branch August 25, 2019 16:14
@danielroe danielroe added the 2.x label Jan 18, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants