examples(coffeescript): update module

[devartyom]

Types of changes

• Bug fix (a non-breaking change which fixes an issue)
• New feature (a non-breaking change which adds functionality)
• Breaking change (fix or feature that would cause existing functionality to change)

Description

Resolves #5423

Checklist:

• My change requires a change to the documentation.
• I have updated the documentation accordingly. (PR: #)
• I have added tests to cover my changes (if not applicable, please state why)
• All new and existing tests are passing.

[pi0]

Are these options identical now? /cc @kevinmarrec

[kevinmarrec]

@pi0 No
https://github.com/nuxt/typescript/blob/master/packages/typescript-build/lib/module.js#L18
We need to be aware that the 2 options aren't used at the same places in core

[kevinmarrec]

options.extensions is more or less related to runtime, meanwhile the others only buildtime

[codecov-io]

Codecov Report

Merging #6248 into dev will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##              dev    #6248   +/-   ##
=======================================
  Coverage   95.72%   95.72%           
=======================================
  Files          80       80           
  Lines        2666     2666           
  Branches      687      687           
=======================================
  Hits         2552     2552           
  Misses         98       98           
  Partials       16       16

Flag	Coverage Δ
#e2e	100% <ø> (ø)	⬆️
#fixtures	50.63% <ø> (ø)	⬆️
#unit	92.42% <ø> (ø)	⬆️

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b22e054...c1e8c0f. Read the comment docs.

[clarkdo]

Any reason for not using additionalExtensions? If extensions cover additionalExtensions, probably we should remove the duplicate one.

[kevinmarrec]

@pi0 @clarkdo If I created a new option it's cause there was a particular need.

All i know is that options.extensions is used to resolves files :
https://github.com/nuxt/nuxt.js/blob/dev/packages/config/src/options.js#L164
https://github.com/nuxt/nuxt.js/blob/dev/packages/core/src/resolver.js#L95

And options.build.additionalExtensions is used to build files that are not .vue or .js around Builder, or mostly create the router from files having these extensions.

This requested change https://github.com/nuxt/nuxt.js/pull/6248/files#diff-4f235fc89b94513b32c2cc8b5896cc5aR47 , would make js duplicated + make Builder build .mjs which Idk if it's relevant.

Having only one extensions would mean that the TypeScript module would make Nuxt also trying to resolve .tsx which shouldn't be needed ?

Idk

EDIT :
Current extensions when using TypeScript module :
options.extensions (for resolvePath core function) : ['js', 'mjs'] + ['ts'] = ['js', 'mjs', 'ts']
builder/router supported extensions : ['vue', 'js'] + additionalExtensions (['ts', 'tsx']) = ['vue', 'js', 'ts', 'tsx']

[pi0]

@kevinmarrec Seems reasonable to have separated ones because of tsx :)

[clarkdo]

Sorry, I didn’t mean that we need to keep only one config, I mean that why we need to merge extensions into supportedExtensions instead of configuring additionalExtensions. For the coffeescript case, only adding this won’t work, user still needs to setup loader. And current change also changed the resolving order and files of routes, it’s kind of breaking change for users having files inside pages dir but not meant to be a route.

[kevinmarrec]

Exactly @clarkdo, cofeescript support for routes should leverage build.additionalExtensions within the cofeescript module.

If somehow cofeescript files should be resolved for other files like serverMiddlewares or local modules, then it should be done like TypeScript module by using both of config extensions options :

https://github.com/nuxt/typescript/blob/master/packages/typescript-build/lib/module.js#L18

[pi0]

The breaking change seems introduced by 2.4.5...2.5.1 -- we are reverting :)

[kevinmarrec]

@pi0 AFAIK routes supported extensions never used options before. It was hardcoded, what breaking change was introduced ?

[pi0]

According to #5423 CoffeeScript support was working and stopped working. But yeah you are right it was hardcoded. src so strange...

[kevinmarrec]

According the issue, a partial fix was found making Vuex World but not local modules, which kind of relevant as to have coffee work everywhere it nows need to be added in both extensions options

I think the fix it just about adding .coffee extension to build.additionalExtensions and nothing more.

There was anyway Indeed something changed in internals. Once upon a time there was a resolveFiles that seemed merging options.extensions inside supportedExtensions of the class that was storint this resolveFiles function

[kevinmarrec]

@pi0 LGTM now, juste need title update