Update package.json #65
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
NODE_ENV is not a recognised command on Windows, the work around is to use the cross-env package or to have two separate scripts, one for Windows and one for Unix based systems. I figured using the cross-env is much more friendly and will save confusion, tested on both Windows and Mac.
Current coverage is 71.09% (diff: 100%)@@ master #65 diff @@
==========================================
Files 10 10
Lines 391 391
Methods 0 0
Messages 0 0
Branches 0 0
==========================================
Hits 278 278
Misses 113 113
Partials 0 0
|
|
Thank you @antcook Will be added to the next release 👍 |
|
This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
On the auth-routes example the start script sets the node environment with NODE_ENV, which is not a recognised command on Windows. The work around is to use the cross-env package or to have two separate scripts, one for Windows and one for Unix based systems. I figured using the cross-env package is much more friendly and will save confusion, tested on both Windows and Mac.