Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(webpack): chunkhash and contenthash not work with extractCSS #6520

Merged
merged 1 commit into from Oct 8, 2019

Conversation

clarkdo
Copy link
Member

@clarkdo clarkdo commented Oct 6, 2019

Types of changes

  • Bug fix (a non-breaking change which fixes an issue)
  • New feature (a non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Description

Fix #6439

extractCSS HMR is unnecessary to be enabled and it will generate timestamp in chunk source, so the chunkhash will be different in multiple builds of same file

Checklist:

  • My change requires a change to the documentation.
  • I have updated the documentation accordingly. (PR: #)
  • I have added tests to cover my changes (if not applicable, please state why)
  • All new and existing tests are passing.

@clarkdo clarkdo requested a review from a team October 6, 2019 16:27
@codecov-io
Copy link

codecov-io commented Oct 6, 2019

Codecov Report

Merging #6520 into dev will increase coverage by <.01%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##              dev    #6520      +/-   ##
==========================================
+ Coverage   95.67%   95.67%   +<.01%     
==========================================
  Files          79       79              
  Lines        2706     2707       +1     
  Branches      698      698              
==========================================
+ Hits         2589     2590       +1     
  Misses        101      101              
  Partials       16       16
Flag Coverage Δ
#e2e 100% <ø> (ø) ⬆️
#fixtures 50.6% <100%> (+0.01%) ⬆️
#unit 92.35% <0%> (-0.04%) ⬇️
Impacted Files Coverage Δ
packages/webpack/src/utils/style-loader.js 94.28% <100%> (+0.16%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7688825...a90b0fd. Read the comment docs.

@pi0 pi0 changed the title fix(build): chunkhash/contenthash not work in extractCSS fix(webpack): chunkhash and contenthash not work with extractCSS Oct 8, 2019
@pi0 pi0 merged commit ed564c3 into dev Oct 8, 2019
@pi0 pi0 deleted the fix/extract-css-hash branch October 8, 2019 08:34
@pi0 pi0 mentioned this pull request Oct 8, 2019
@danielroe danielroe added the 2.x label Jan 18, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

chunkhash / contenthash not work,每次build生成的hash都不一样
4 participants