Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

v2.10.1 #6529

Merged
merged 19 commits into from
Oct 11, 2019
Merged

v2.10.1 #6529

merged 19 commits into from
Oct 11, 2019

Conversation

pi0
Copy link
Member

@pi0 pi0 commented Oct 8, 2019

🐞 Fixes

🏑 Chore

βš“ Dependency Upgrades

  • vue-meta: Upgraded to v2.3 which fixes duplicated tags in SPA mode

πŸ’– Thanks to

@pi0 pi0 requested a review from a team October 8, 2019 09:08
@pi0 pi0 changed the title v2.10.0 v2.10.1 Oct 8, 2019
@codecov-io
Copy link

codecov-io commented Oct 8, 2019

Codecov Report

Merging #6529 into 2.x will increase coverage by 0.22%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##              2.x    #6529      +/-   ##
==========================================
+ Coverage   95.67%   95.89%   +0.22%     
==========================================
  Files          79       78       -1     
  Lines        2706     2705       -1     
  Branches      698      699       +1     
==========================================
+ Hits         2589     2594       +5     
+ Misses        101       96       -5     
+ Partials       16       15       -1
Flag Coverage Ξ”
#e2e 100% <ΓΈ> (ΓΈ) ⬆️
#fixtures 64.73% <62.5%> (+14.14%) ⬆️
#unit 92.34% <87.5%> (-0.04%) ⬇️
Impacted Files Coverage Ξ”
packages/webpack/src/config/base.js 92.07% <ΓΈ> (ΓΈ) ⬆️
packages/webpack/src/utils/style-loader.js 94.28% <100%> (+0.16%) ⬆️
packages/cli/src/commands/build.js 86.36% <100%> (ΓΈ) ⬆️
packages/utils/src/route.js 100% <100%> (ΓΈ) ⬆️
packages/generator/src/generator.js 100% <100%> (ΓΈ) ⬆️
packages/vue-renderer/src/renderer.js 94.3% <0%> (+0.81%) ⬆️
packages/cli/src/utils/index.js 94.44% <0%> (+5.55%) ⬆️
packages/cli/src/commands/index.js 55.55% <0%> (+44.44%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Ξ” = absolute <relative> (impact), ΓΈ = not affected, ? = missing data
Powered by Codecov. Last update c17afa7...9d9ae21. Read the comment docs.

Copy link

@pimlie pimlie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

#6525 showed we have a serious gap in our tests. The danger of merging the fix without any tests to fill that gap is that adding those tests will be postponed indefinitely

Can we somehow add those tests (somewhat quickly) so we are releasing a fix which we can guarantee shouldnt happen again?

@vinayakkulkarni
Copy link

Lowkey hoping this gets released sooner than later.

Got few of my projects hanging on v2.9.x

@pi0
Copy link
Member Author

pi0 commented Oct 9, 2019

@vinayakkulkarni I hope so. We are just pending for #6533 broken unit test.

Copy link

@pimlie pimlie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

#6537 adds new tests which should mostly close the gap mentioned above

@clarkdo
Copy link
Member

clarkdo commented Oct 9, 2019

@pi0 The error comes from memory-fs@0.5.0. We're using ^0.4.2 now, so it should be safe to release and I'll look into upgradation error.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet