-
-
Notifications
You must be signed in to change notification settings - Fork 4.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. Weβll occasionally send you account related emails.
Already on GitHub? Sign in to your account
v2.10.1 #6529
Conversation
Codecov Report
@@ Coverage Diff @@
## 2.x #6529 +/- ##
==========================================
+ Coverage 95.67% 95.89% +0.22%
==========================================
Files 79 78 -1
Lines 2706 2705 -1
Branches 698 699 +1
==========================================
+ Hits 2589 2594 +5
+ Misses 101 96 -5
+ Partials 16 15 -1
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
#6525 showed we have a serious gap in our tests. The danger of merging the fix without any tests to fill that gap is that adding those tests will be postponed indefinitely
Can we somehow add those tests (somewhat quickly) so we are releasing a fix which we can guarantee shouldnt happen again?
Lowkey hoping this gets released sooner than later. Got few of my projects hanging on v2.9.x |
@vinayakkulkarni I hope so. We are just pending for #6533 broken unit test. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
#6537 adds new tests which should mostly close the gap mentioned above
@pi0 The error comes from |
π Fixes
vue-app, webpack
utils
router.trailingSlash
isfalse
generator
webpack
chunkhash
andcontenthash
not work withextractCSS
Β #6520chunkhash
andcontenthash
not work withextractCSS
cli
nuxt build
when pages should be generatedπ‘ Chore
readme
β Dependency Upgrades
vue-meta
: Upgraded tov2.3
which fixes duplicated tags in SPA modeπ Thanks to