Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(generator): remove trailingSlash for chunkId #7336

Merged
merged 1 commit into from
May 8, 2020
Merged

fix(generator): remove trailingSlash for chunkId #7336

merged 1 commit into from
May 8, 2020

Conversation

atinux
Copy link
Member

@atinux atinux commented May 8, 2020 •
edited
Loading

Types of changes

  • Bug fix (a non-breaking change which fixes an issue)
  • New feature (a non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Description

Avoid generating two times the same route when a link has a trailing slash.
Also force to remove the trailing slash for payload chunk id.

Checklist:

  • All new and existing tests are passing.

[release]

@atinux atinux requested a review from pi0 May 8, 2020 15:58
@atinux atinux merged commit 8e2d976 into dev May 8, 2020
@atinux atinux deleted the fix/trailing-slash branch May 8, 2020 16:10
@pi0 pi0 mentioned this pull request Jun 10, 2020
Merged
@danielroe danielroe added the 2.x label Jan 18, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pi0 pi0 pi0 approved these changes

Assignees
No one assigned
Labels
2.x
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@atinux @pi0 @danielroe