Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(generator): respect options.router.trailingSlash for crawler #7431

Merged
merged 2 commits into from May 28, 2020

Conversation

manniL
Copy link
Member

@manniL manniL commented May 28, 2020

Types of changes

  • Bug fix (a non-breaking change which fixes an issue)

Description

When crawling and enforcing a trailing slash, all pages will be crawled twice because the trailing slash is skipped. This also leads to massive errors because pages without trailing slashes can't be generated (as they throw a 404 when enforcing a trailing slash)

@manniL manniL changed the title fix: let crawler respect trailing slash enforcement fix(crawler): respect trailing slash enforcement May 28, 2020
@manniL manniL requested a review from pi0 May 28, 2020 16:01
@codecov-commenter
Copy link

Codecov Report

Merging #7431 into dev will decrease coverage by 0.03%.
The diff coverage is 0.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##              dev    #7431      +/-   ##
==========================================
- Coverage   70.26%   70.22%   -0.04%     
==========================================
  Files          88       88              
  Lines        3696     3698       +2     
  Branches     1008     1009       +1     
==========================================
  Hits         2597     2597              
- Misses        892      893       +1     
- Partials      207      208       +1     
Flag Coverage Δ
#unittests 70.22% <0.00%> (-0.04%) ⬇️
Impacted Files Coverage Δ
packages/generator/src/generator.js 85.42% <0.00%> (-0.87%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2e711c1...981b474. Read the comment docs.

@manniL manniL requested review from Atinux and a team May 28, 2020 16:09
Copy link
Member

@pi0 pi0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! Seems we need a utility for trailing slash asap

@pi0 pi0 changed the title fix(crawler): respect trailing slash enforcement fix(generator): respect options.router.trailingSlash May 28, 2020
@pi0 pi0 changed the title fix(generator): respect options.router.trailingSlash fix(generator): respect options.router.trailingSlash for crawler May 28, 2020
@pi0 pi0 merged commit c144716 into dev May 28, 2020
@pi0 pi0 deleted the fix/respect-trailing branch May 28, 2020 16:26
@pi0 pi0 mentioned this pull request Jun 10, 2020
@danielroe danielroe added the 2.x label Jan 18, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants