fix(webpack): reduce false negatives in nodeExternals (#7462)

[JohannesLamberts]

Types of changes

• Bug fix (a non-breaking change which fixes an issue)
• New feature (a non-breaking change which adds functionality)
• Breaking change (fix or feature that would cause existing functionality to change)

This could change behaviour in existing SSR-Apps. The behaviour is however undocumented and unintended (afaik).

Description

Resolves: #7462

Checklist:

• My change requires a change to the documentation.
• I have updated the documentation accordingly. (PR: #)
• I have added tests to cover my changes (if not applicable, please state why)
• All new and existing tests are passing.

I'm not sure how/if the changes can be tested and would be grateful for guiding/support.

[codecov-commenter]

Codecov Report

Merging #7464 into dev will decrease coverage by 0.04%.
The diff coverage is 25.00%.

@@            Coverage Diff             @@
##              dev    #7464      +/-   ##
==========================================
- Coverage   70.32%   70.28%   -0.05%     
==========================================
  Files          88       88              
  Lines        3704     3708       +4     
  Branches     1010     1011       +1     
==========================================
+ Hits         2605     2606       +1     
- Misses        892      894       +2     
- Partials      207      208       +1     

Flag	Coverage Δ
#unittests	70.28% <25.00%> (-0.05%)	⬇️

Impacted Files	Coverage Δ
packages/webpack/src/config/server.js	2.38% <25.00%> (+2.38%)	⬆️

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update cbbf665...4354c29. Read the comment docs.

[JohannesLamberts]

@pi0 is there anything more to do for me or can this be merged?

[pi0]

@JohannesLamberts No, actually it is perfect. Would be nice removing jsx as well if you have time :)

[JohannesLamberts]

@pi0 done, I also removed the RegEx to reduce complexity

[pi0]

Amazing thanks ❤️ Waiting for tests to pass

[JohannesLamberts]

@pi0 https://github.com/nuxt/nuxt.js/pull/7464/checks?check_run_id=750834024 failed with

jest packages --forceExit --coverage
/bin/sh: 1: jest: not found

I cannot see how this could be related to the code changes :/