Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(vue-app): don't fetch payload for store mutation for preview and spa fallback #7723

Merged
merged 1 commit into from
Jul 16, 2020

Conversation

atinux
Copy link
Member

@atinux atinux commented Jul 16, 2020

…a fallback

Types of changes

  • Bug fix (a non-breaking change which fixes an issue)
  • New feature (a non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Description

Checklist:

  • My change requires a change to the documentation.
  • I have updated the documentation accordingly. (PR: #)
  • I have added tests to cover my changes (if not applicable, please state why)
  • All new and existing tests are passing.

@atinux atinux requested a review from pi0 July 16, 2020 14:21
@codecov-commenter
Copy link

Codecov Report

Merging #7723 into dev will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##              dev    #7723   +/-   ##
=======================================
  Coverage   70.13%   70.13%           
=======================================
  Files          88       88           
  Lines        3764     3764           
  Branches     1025     1025           
=======================================
  Hits         2640     2640           
  Misses        913      913           
  Partials      211      211           
Flag Coverage Δ
#unittests 70.13% <ø> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e537e8c...2638bb4. Read the comment docs.

@pi0 pi0 changed the title fix(vue-app): don't fetch payload for store mutation if preview or sp… fix(vue-app): don't fetch payload for store mutation for preview and spa fallback Jul 16, 2020
@pi0 pi0 merged commit f81c588 into dev Jul 16, 2020
@pi0 pi0 deleted the fix/bad-payload-fetch branch July 16, 2020 15:10
@pi0 pi0 mentioned this pull request Jul 22, 2020
@danielroe danielroe added the 2.x label Jan 18, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants