-
-
Notifications
You must be signed in to change notification settings - Fork 5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(webpack): ensure loaders are first searched from @nuxt/webpack
#7787
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the PR @matthieusieben. It would be nice if you can provide a reproduction for bug-fixes/reports too so we can ensure this fix works
Reproduce like so:
Run
The "right" |
@matthieusieben I made a reproduction accordingly: https://github.com/pi0/nuxt-7787 Issue is reproducible but this change won't fix it! We may have to resolve 'css-loader' like this: const cssLoader = { loader: require.resolve('css-loader'), options }; |
This was my first approach but there are two issues with it:
|
@matthieusieben With 93753d3 i can confirm it was fixing issue :) |
@nuxt/webpack
Codecov Report
@@ Coverage Diff @@
## dev #7787 +/- ##
=======================================
Coverage 68.88% 68.88%
=======================================
Files 90 90
Lines 3834 3834
Branches 1037 1037
=======================================
Hits 2641 2641
Misses 969 969
Partials 224 224
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
Have a look at https://github.com/matthieusieben/nuxt-7787
|
For me too. |
Failing windows CI is not related to this PR |
Types of changes
Description
When nuxt is used as part of a mono repo, NPM & Yarn may install
@nuxt/webpack
's dependencies in@nuxt/webpack/node_modules
instead of the project's root folder. When that is the case, Webpack is not able to find these loaders.Checklist: