fix: remove completly reactivityTransform option

nuxt · Nov 27, 2023 · 2d480e4 · 2d480e4
1 parent db69498
commit 2d480e4
Show file tree

Hide file tree

Showing 6 changed files with 1 addition and 34 deletions.
diff --git a/docs/2.guide/3.going-further/1.experimental-features.md b/docs/2.guide/3.going-further/1.experimental-features.md
@@ -39,20 +39,6 @@ export defineNuxtConfig({
 })
 ```
 
-## reactivityTransform
-
-Enables Vue's reactivity transform. Note that this feature has been marked as deprecated in Vue 3.3 and is planned to be removed from core in Vue 3.4.
-
-```ts [nuxt.config.ts]
-export defineNuxtConfig({
-  experimental: {
-    reactivityTransform: true
-  }
-})
-```
-
-:read-more{to="/docs/getting-started/configuration#enabling-experimental-vue-features"}
-
 ## externalVue
 
 Externalizes `vue`, `@vue/*` and `vue-router` when building.

diff --git a/packages/kit/src/template.ts b/packages/kit/src/template.ts
@@ -218,10 +218,6 @@ export async function writeTypes (nuxt: Nuxt) {
     .filter(f => typeof f === 'string')
     .map(async id => ({ types: (await readPackageJSON(id, { url: nodeModulePaths }).catch(() => null))?.name || id })))
 
-  if (nuxt.options.experimental?.reactivityTransform) {
-    references.push({ types: 'vue/macros-global' })
-  }
-
   const declarations: string[] = []
 
   await nuxt.callHook('prepare:types', { references, declarations, tsConfig })

diff --git a/packages/schema/src/config/experimental.ts b/packages/schema/src/config/experimental.ts
@@ -9,16 +9,6 @@ export default defineUntypedSchema({
       $resolve: val => val ?? false
     },
 
-    /**
-     * Enable Vue's reactivity transform
-     * @see [Vue Reactivity Transform Docs](https://vuejs.org/guide/extras/reactivity-transform.html)
-     *
-     * Warning: Reactivity transform feature has been marked as deprecated in Vue 3.3 and is planned to be
-     * removed from core in Vue 3.4.
-     * @see [Vue RFC#369](https://github.com/vuejs/rfcs/discussions/369#discussioncomment-5059028)
-     */
-    reactivityTransform: false,
-
     // TODO: Remove when nitro has support for mocking traced dependencies
     // https://github.com/unjs/nitro/issues/1118
     /**

diff --git a/packages/vite/src/vite.ts b/packages/vite/src/vite.ts
@@ -110,7 +110,6 @@ export const bundle: NuxtBuilder['bundle'] = async (nuxt) => {
           virtual(nuxt.vfs)
         ],
         vue: {
-          reactivityTransform: nuxt.options.experimental.reactivityTransform,
           template: {
             transformAssetUrls: {
               video: ['src', 'poster'],

diff --git a/packages/webpack/src/presets/vue.ts b/packages/webpack/src/presets/vue.ts
@@ -12,10 +12,7 @@ export function vue (ctx: WebpackConfigContext) {
   ctx.config.module!.rules!.push({
     test: /\.vue$/i,
     loader: 'vue-loader',
-    options: {
-      reactivityTransform: ctx.nuxt.options.experimental.reactivityTransform,
-      ...ctx.userConfig.loaders.vue
-    }
+    options: ctx.userConfig.loaders.vue
   })
 
   if (ctx.isClient) {

diff --git a/test/fixtures/basic/nuxt.config.ts b/test/fixtures/basic/nuxt.config.ts
@@ -198,7 +198,6 @@ export default defineNuxtConfig({
     restoreState: true,
     inlineSSRStyles: id => !!id && !id.includes('assets.vue'),
     componentIslands: true,
-    reactivityTransform: true,
     treeshakeClientOnly: true,
     asyncContext: process.env.TEST_CONTEXT === 'async',
     appManifest: process.env.TEST_MANIFEST !== 'manifest-off',