Skip to content

Commit

Permalink
hotfix(vue-app): ReferenceError error passed with routeChanged (#4444)
Browse files Browse the repository at this point in the history
  • Loading branch information
aldarund authored and Sébastien Chopin committed Nov 28, 2018
1 parent 0f28f9c commit 6ed3eca
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion packages/vue-app/template/client.js
Expand Up @@ -145,7 +145,7 @@ async function loadAsyncComponents(to, from, next) {
// Call next()
next()
} catch (err) {
this.error(err)
const error = this.error(err)
this.<%= globals.nuxt %>.$emit('routeChanged', to, from, error)

This comment has been minimized.

Copy link
@buremba

buremba Jan 22, 2019

This change is not included in last version and we run into issues in production, is it possible for you to release the version that includes this fix?

This comment has been minimized.

Copy link
@manniL

manniL Jan 22, 2019

Member

@buremba Sorry to hear that 😦

Please bear with us as a new minor version is coming. We will backport fixes like that more frequently after that.

Feel free to switch to nuxt-edge for now (by removing nuxt and adding nuxt-edge to your dependencies). It should include the fix

This comment has been minimized.

Copy link
@buremba

buremba Jan 22, 2019

Thanks for the info @manniL

This comment has been minimized.

Copy link
@buremba

buremba Jan 27, 2019

@manniL any updates for the new minor version?

This comment has been minimized.

Copy link
@manniL

manniL Jan 27, 2019

Member

@buremba Yes! Would've been already released if there hadn't been that Twitter incident 🙈

PS: Saw your comment on #4681

#4853 might make you very happy ☺️

This comment has been minimized.

Copy link
@buremba

buremba Jan 27, 2019

It looks great @manniL, thanks for maintaining this great library! 👏

next(false)
}
Expand Down

0 comments on commit 6ed3eca

Please sign in to comment.