fix: not send Server-Timing header if no timing info

nuxt · Feb 14, 2019 · d9a0b5f · d9a0b5f
1 parent c6d8e8f
commit d9a0b5f
Showing 1 changed file with 13 additions and 8 deletions.
diff --git a/packages/server/src/middleware/timing.js b/packages/server/src/middleware/timing.js
@@ -15,13 +15,16 @@ export default options => (req, res, next) => {
   onHeaders(res, () => {
     res.timing.end('total')
 
-    res.setHeader(
-      'Server-Timing',
-      []
-        .concat(res.getHeader('Server-Timing') || [])
-        .concat(res.timing.headers)
-        .join(', ')
-    )
+    if (res.timing.headers.length > 0) {
+      res.setHeader(
+        'Server-Timing',
+        []
+          .concat(res.getHeader('Server-Timing') || [])
+          .concat(res.timing.headers)
+          .join(', ')
+      )
+    }
+    res.timing.clear()
   })
 
   next()
@@ -35,7 +38,9 @@ class ServerTiming extends Timer {
 
   end(...args) {
     const time = super.end(...args)
-    this.headers.push(this.formatHeader(time))
+    if (time) {
+      this.headers.push(this.formatHeader(time))
+    }
     return time
   }