Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Downgrade engine checks to Node v16.10+ (Node v16.11+ has a memory leak with jest) #15047

Closed
jcao02 opened this issue Sep 27, 2022 · 1 comment · Fixed by nuxt/framework#7865

Comments

@jcao02
Copy link

jcao02 commented Sep 27, 2022

Environment

  • Operating System: Darwin
  • Node Version: v16.15.0
  • Nuxt Version: 2.15.8
  • Nitro Version: -
  • Package Manager: pnpm@7.12.1
  • Builder: webpack
  • User Config: -
  • Runtime Modules: -
  • Build Modules: -

Reproduction

  • Use Node v16.10.x
  • Install @nuxtjs/tailwindcss@5.3.3 and webpack@4.46.0

Describe the bug

In the package @nuxt/kit, the latest RC (rc.11) has an engine check for ^16.11.x (see here). This is a problem because Jest has a known memory leak from Node v16.11.x.

This poses a problem to organisations that use Nuxt + Jest at scale, where CI instances run out of memory (or they become very expensive to support the vertical scaling).

Additional context

No response

Logs

No response

@danielroe
Copy link
Member

Related: https://github.com/nuxt/framework/discussions/1234.

I'm not sure why 16.11 vs 16.10 was chosen. Tests seem to pass fine within the monorepo on 16.10, but @pi0 may have more context on this.

For context, see Node v16.11 changelog

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants