You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
greimela
changed the title
Default scroll behavior without page transition is broken in rc-13
Default scroll behavior without page transition is broken in rc.13
Nov 4, 2022
Related issue: https://github.com/nuxt/framework/issues/8699
`router.options.ts` falsely thinks that an `undefined` page transition is `true`, meaning it HAS a transition.
Whereas `page.mjs` correctly interprets an `undefined` transition as `false`.
Environment
Darwin
v16.13.1
3.0.0-rc.13
0.6.1
yarn@1.22.15
vite
alias
,app
,build
,modules
,progress
,plausible
,runtimeConfig
,vite
@nuxtjs/tailwindcss@6.1.3
,nuxt-progress@0.1.6
,vue-plausible@1.3.2
-
Reproduction
https://stackblitz.com/edit/github-ruxdek?file=pages/index.vue
Describe the bug
Reproduction:
Expected behavior:
Actual behavior:
The reason is that
router.options.ts
falsely thinks that anundefined
page transition istrue
, meaning it HAS a transition.https://github.com/nuxt/framework/blob/bde96947333501c22a5e981515bd27c24eb8b88f/packages/nuxt/src/pages/runtime/router.options.ts#L34
Whereas
page.mjs
correctly interprets anundefined
transition asfalse
.https://github.com/nuxt/framework/blob/bde96947333501c22a5e981515bd27c24eb8b88f/packages/nuxt/src/pages/runtime/page.ts#L46
I will submit a PR to fix this issue.
Additional context
No response
Logs
No response
The text was updated successfully, but these errors were encountered: