Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remote sources is not working due to a joinURL #23092

Closed
huang-julien opened this issue Sep 8, 2023 · 0 comments · Fixed by #23093
Closed

remote sources is not working due to a joinURL #23092

huang-julien opened this issue Sep 8, 2023 · 0 comments · Fixed by #23093

Comments

@huang-julien
Copy link
Member

Environment


  • Operating System: Windows_NT
  • Node Version: v18.15.0
  • Nuxt Version: 3.7.1
  • CLI Version: 3.7.3
  • Nitro Version: 2.6.2
  • Package Manager: pnpm@8.6.0
  • Builder: -
  • User Config: -
  • Runtime Modules: -
  • Build Modules: -

Reproduction

try any remote source

Describe the bug

      const r = await eventFetch(withQuery(import.meta.dev && import.meta.client ? url : joinURL(config.app.baseURL ?? '', url), {
        ...props.context,
        props: props.props ? JSON.stringify(props.props) : undefined
      }))

There's a missing || props.source in the condition. NuxtIsland is trying to joinURL the baseURL or an empty string with a fullURL resulting in /${fullURL}

Additional context

No response

Logs

No response

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants