Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(nuxt): don't joinURL with remote sources on NuxtIsland #23093

Merged
merged 2 commits into from Sep 8, 2023

Conversation

huang-julien
Copy link
Member

@huang-julien huang-julien commented Sep 8, 2023

πŸ”— Linked issue

fix #23092

❓ Type of change

  • πŸ“– Documentation (updates to the documentation, readme or JSdoc annotations)
  • 🐞 Bug fix (a non-breaking change that fixes an issue)
  • πŸ‘Œ Enhancement (improving an existing functionality like performance)
  • ✨ New feature (a non-breaking change that adds functionality)
  • 🧹 Chore (updates to the build process or auxiliary tools and libraries)
  • ⚠️ Breaking change (fix or feature that would cause existing functionality to change)

πŸ“š Description

Hi πŸ‘‹

When doing a previous fix on adding baseURL for nuxt islands, and merging the remote sources PR after it, a condition hasn't been updated causing remote islands to not work

πŸ“ Checklist

  • I have linked an issue or discussion.
  • I have updated the documentation accordingly.

@stackblitz
Copy link

stackblitz bot commented Sep 8, 2023

Review PR in StackBlitz Codeflow Run & review this pull request in StackBlitz Codeflow.

@huang-julien
Copy link
Member Author

@danielroe do you know if there's a way to test remote island on the repo ? I don't think we can start two seperate servers on fixtures tests and this would cost a lot of time on the CI.
Maybe starting a small h3 server which would listen to 3001 when running a specific test ?

@danielroe
Copy link
Member

I think it might be sufficient to provide a mock endpoint, which we could create in the test suite?

@huang-julien
Copy link
Member Author

Do you mean something like <NuxtIsland source="/mock/island" > ?

@danielroe
Copy link
Member

Or even fire up a mock server with listhen + h3 with a URL....

@huang-julien
Copy link
Member Author

A mock server may be the best solution atm, I don't think having /mock/island would work as a second argument of new URL(), it will probably throw

@huang-julien huang-julien marked this pull request as draft September 8, 2023 19:12
@huang-julien
Copy link
Member Author

huang-julien commented Sep 8, 2023

Setting this to draft, i need to verify something on URL
I think we can set up theses test on anoither PR ? Or shall we do it on this one ?
Edit: all's good

@huang-julien huang-julien marked this pull request as ready for review September 8, 2023 19:14
@danielroe danielroe merged commit dfdebf2 into nuxt:main Sep 8, 2023
25 checks passed
@github-actions github-actions bot mentioned this pull request Sep 8, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

remote sources is not working due to a joinURL
2 participants