fix(vue-app): check for Page.options before looking within #8612
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## dev #8612 +/- ##
=======================================
Coverage 66.02% 66.02%
=======================================
Files 92 92
Lines 4009 4009
Branches 1103 1103
=======================================
Hits 2647 2647
Misses 1095 1095
Partials 267 267
Flags with carried forward coverage won't be shown. Click here to find out more. Continue to review full report at Codecov.
|
atinux
reviewed
Jan 9, 2021
| @@ -31,9 +31,9 @@ export default function (to, from, savedPosition) { | |||
| // Scroll to the top of the page if... | |||
| if ( | |||
| // One of the children set `scrollToTop` | |||
| (Pages.some(Page => Page.options.scrollToTop) || | |||
| (Pages.some(Page => Page.options && Page.options.scrollToTop) || | |||
There was a problem hiding this comment.
Could we use this?
Suggested change
| (Pages.some(Page => Page.options && Page.options.scrollToTop) || | |
| (Pages.some(Page => Page.options?.scrollToTop) || |
There was a problem hiding this comment.
This may add extra polyfill if user is not using optional chaining.
There was a problem hiding this comment.
Let's merge this and I may make some refactoring to this file after the fix
clarkdo
approved these changes
Jan 11, 2021
7 tasks
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Types of changes
Description
Difficult to reproduce the issue but the fix is lightweight.
closes #8234
Checklist: