Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix incorrect Cache-Busting for CSS #1390

Merged
merged 1 commit into from Aug 16, 2017
Merged

Fix incorrect Cache-Busting for CSS #1390

merged 1 commit into from Aug 16, 2017

Conversation

menthol
Copy link

@menthol menthol commented Aug 16, 2017

@codecov-io
Copy link

Codecov Report

Merging #1390 into dev will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##              dev    #1390   +/-   ##
=======================================
  Coverage   92.63%   92.63%           
=======================================
  Files          12       12           
  Lines         788      788           
=======================================
  Hits          730      730           
  Misses         58       58
Impacted Files Coverage Δ
lib/common/options.js 89.13% <ø> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d7d85d3...640288c. Read the comment docs.

@pi0
Copy link
Member

pi0 commented Aug 16, 2017

Hi. Thanks for the PR and tip. Seems contenthash is only specific to extractTextPlugin. Also vue-hacker-news uses chunkhash for css assets too.
What's your idea adding a condition to use chunkhash when extractCSS is false?

UPDATE Never mind :D that's not even needed as this name is only used for this plugin :))

@pi0 pi0 merged commit 9db1100 into nuxt:dev Aug 16, 2017
@lock
Copy link

lock bot commented Nov 1, 2018

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@lock lock bot locked as resolved and limited conversation to collaborators Nov 1, 2018
@danielroe danielroe added the 2.x label Jan 18, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants