feat(nuxt): start loading indicator state with middleware #21003
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
danielroe
reviewed
Jun 6, 2023
| @@ -30,7 +30,7 @@ export default defineComponent({ | |||
| // Hook to app lifecycle | |||
| // TODO: Use unified loading API | |||
| const nuxtApp = useNuxtApp() | |||
| nuxtApp.hook('page:start', indicator.start) | |||
| nuxtApp.hook('router:beforeMiddleware', indicator.start) | |||
There was a problem hiding this comment.
what about using useRouter().beforeEach(indicator.start) and afterEach instead of introducing new hooks?
There was a problem hiding this comment.
Pushed an implementation - what do you think? Do you see any issues with this approach?
danielroe
changed the title
<NuxtLoadingIndicator> takes middlewares into account
danielroe
approved these changes
Jun 16, 2023
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🔗 Linked issue
This PR aims to fix issue #19528.
❓ Type of change
📚 Description
This PR introduces 2 new router hooks:
router:beforeMiddlewareandrouter:afterMiddleware. These hooks can be useful on their own, but this PR also changes<NuxtLoadingIndicator>so it relies onrouter:beforeMiddleware, making it reflect any middleware latency.Resolves #19528.
📝 Checklist