Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(nuxt): treeshake <DevOnly> with webpack #21013

Merged
merged 2 commits into from May 22, 2023
Merged

fix(nuxt): treeshake <DevOnly> with webpack #21013

merged 2 commits into from May 22, 2023

Conversation

huang-julien
Copy link
Member

🔗 Linked issue

fix #21012

❓ Type of change

  • 📖 Documentation (updates to the documentation, readme or JSdoc annotations)
  • 🐞 Bug fix (a non-breaking change that fixes an issue)
  • 👌 Enhancement (improving an existing functionality like performance)
  • ✨ New feature (a non-breaking change that adds functionality)
  • 🧹 Chore (updates to the build process or auxiliary tools and libraries)
  • ⚠️ Breaking change (fix or feature that would cause existing functionality to change)

📚 Description

📝 Checklist

  • I have linked an issue or discussion.
  • I have updated the documentation accordingly.

@huang-julien huang-julien changed the title fix(nuxt): treeshake <devonly> with webpack fix(nuxt): treeshake <DevOnly> with webpack May 22, 2023
@huang-julien huang-julien marked this pull request as ready for review May 22, 2023 19:32
@huang-julien @ineshbose
Update packages/nuxt/src/core/plugins/dev-only.ts
b3b9deb 
Co-authored-by: Inesh Bose <56732164+ineshbose@users.noreply.github.com>
@danielroe danielroe merged commit 7cc7297 into nuxt:main May 22, 2023
19 checks passed
This was referenced May 22, 2023
Merged
Closed
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@danielroe danielroe danielroe approved these changes

@ineshbose ineshbose ineshbose approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

DevOnly is not treeshaken with webpack
3 participants
@huang-julien @danielroe @ineshbose