fix(nuxt): show error page after fatal abortNavigation
#21047
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
xanderbarkhatov
changed the title
abortNavigation
|
Not sure if it's okay to do it here, but felt cleaner than in /plugins/router.ts as we only want to do it for fatal errors if I understood right |
danielroe
reviewed
May 25, 2023
…rkhatov/nuxt into fix/abort-navigation-error-page
danielroe
approved these changes
May 25, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🔗 Linked issue
resolves #15053
❓ Type of change
📚 Description
Show error page if
fatal: trueoption was passed toabortNavigation📝 Checklist