Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(nuxt): skip vue render when redirecting #21412

Merged
merged 10 commits into from Jun 7, 2023
Merged

fix(nuxt): skip vue render when redirecting #21412

merged 10 commits into from Jun 7, 2023

Conversation

danielroe
Copy link
Member

πŸ”— Linked issue

resolves #20696

❓ Type of change

  • πŸ“– Documentation (updates to the documentation, readme or JSdoc annotations)
  • 🐞 Bug fix (a non-breaking change that fixes an issue)
  • πŸ‘Œ Enhancement (improving an existing functionality like performance)
  • ✨ New feature (a non-breaking change that adds functionality)
  • 🧹 Chore (updates to the build process or auxiliary tools and libraries)
  • ⚠️ Breaking change (fix or feature that would cause existing functionality to change)

πŸ“š Description

When we have an early response (for example, redirection), we can completely skip rendering the html for the page; we're not going to send it back. We can abort the rendering process with a targeted thrown/handled error.

πŸ“ Checklist

  • I have linked an issue or discussion.
  • I have updated the documentation accordingly.

@danielroe danielroe changed the title fix(nuxt): allow skipping vue render when we already have response fix(nuxt): skip vue render when redirecting Jun 7, 2023
@danielroe danielroe merged commit 7710ed3 into main Jun 7, 2023
22 checks passed
@danielroe danielroe deleted the fix/setup-twice branch June 7, 2023 12:18
@github-actions github-actions bot mentioned this pull request Jun 7, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Page setup and middleware running twice after SSR middleware redirect
2 participants