Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(nuxt): allow remote sources for islands #21592

Merged
merged 3 commits into from Jul 30, 2023

Conversation

huang-julien
Copy link
Member

@huang-julien huang-julien commented Jun 15, 2023

πŸ”— Linked issue

resolve #12343
linked #19772

❓ Type of change

  • πŸ“– Documentation (updates to the documentation, readme or JSdoc annotations)
  • 🐞 Bug fix (a non-breaking change that fixes an issue)
  • πŸ‘Œ Enhancement (improving an existing functionality like performance)
  • ✨ New feature (a non-breaking change that adds functionality)
  • 🧹 Chore (updates to the build process or auxiliary tools and libraries)
  • ⚠️ Breaking change (fix or feature that would cause existing functionality to change)

πŸ“š Description

Hi πŸ‘‹ (this pr has been sleeping for a while now...)

This should be considered as HIGHLY experimental

This PR opens the door to remote islands and introduce a new fallback slot for NuxtIslands which will show up if the component failed to fetch the island component

This feature can be enabled like this:

export default defineNuxtConfig({
  experimental: {
    componentIslands: 'local+remote'
  }
})

πŸ“ Checklist

  • I have linked an issue or discussion.
  • I have updated the documentation accordingly.

@danielroe danielroe added the 3.x label Jun 15, 2023
@huang-julien huang-julien marked this pull request as ready for review June 21, 2023 21:12
@huang-julien
Copy link
Member Author

Tested with multiple tunnel locally. I wonder if its possible to test it within e2e fixtures

@danielroe danielroe added this to the 3.7 milestone Jun 23, 2023
@danielroe danielroe merged commit ffc4e79 into nuxt:main Jul 30, 2023
29 checks passed
@github-actions github-actions bot mentioned this pull request Jul 30, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

hybrid islands (with remote sources)
2 participants