Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(nuxt): replace : in rendered server components (for win) #21645

Merged
merged 2 commits into from Jun 19, 2023

Conversation

danielroe
Copy link
Member

πŸ”— Linked issue

❓ Type of change

  • πŸ“– Documentation (updates to the documentation, readme or JSdoc annotations)
  • 🐞 Bug fix (a non-breaking change that fixes an issue)
  • πŸ‘Œ Enhancement (improving an existing functionality like performance)
  • ✨ New feature (a non-breaking change that adds functionality)
  • 🧹 Chore (updates to the build process or auxiliary tools and libraries)
  • ⚠️ Breaking change (fix or feature that would cause existing functionality to change)

πŸ“š Description

On Windows : is not a valid character and so these files were never being written - instead empty files with their file names truncated at :.

πŸ“ Checklist

  • I have linked an issue or discussion.
  • I have updated the documentation accordingly.

@danielroe danielroe changed the title fix(nuxt): do not use : in written file paths on windows fix(nuxt): do not use : in written file paths (for windows support) Jun 19, 2023
@danielroe danielroe changed the title fix(nuxt): do not use : in written file paths (for windows support) fix(nuxt): replace : in rendered server components (for win) Jun 19, 2023
@danielroe danielroe merged commit 3fd6c17 into main Jun 19, 2023
24 checks passed
@danielroe danielroe deleted the fix/remove-colon branch June 19, 2023 22:06
@github-actions github-actions bot mentioned this pull request Jun 19, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant