Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(nuxt): move to @typescript-eslint/typescript-estree #21664

Merged
merged 3 commits into from Jun 20, 2023

Conversation

c-schwan
Copy link
Contributor

πŸ”— Linked issue

#21662

❓ Type of change

  • πŸ“– Documentation (updates to the documentation, readme or JSdoc annotations)
  • 🐞 Bug fix (a non-breaking change that fixes an issue)
  • πŸ‘Œ Enhancement (improving an existing functionality like performance)
  • ✨ New feature (a non-breaking change that adds functionality)
  • 🧹 Chore (updates to the build process or auxiliary tools and libraries)
  • ⚠️ Breaking change (fix or feature that would cause existing functionality to change)

πŸ“š Description

This package was moved to @typescript-eslint/typescript-estree

πŸ“ Checklist

  • I have linked an issue or discussion.
  • I have updated the documentation accordingly.

@danielroe
Copy link
Member

We also need to update the implementation here:

import { parse } from 'typescript-estree'

@c-schwan c-schwan changed the title Update package.json Update package typescript-estree Jun 20, 2023
@c-schwan c-schwan changed the title Update package typescript-estree feat(nuxt): package typescript-estree Jun 20, 2023
@danielroe danielroe changed the title feat(nuxt): package typescript-estree fix(nuxt): move to @typescript-eslint/typescript-estree Jun 20, 2023
@danielroe
Copy link
Member

Thank you - good spot!

@danielroe danielroe merged commit 5460873 into nuxt:main Jun 20, 2023
28 checks passed
@github-actions github-actions bot mentioned this pull request Jun 20, 2023
@favna
Copy link

favna commented Jun 23, 2023

At time of writing this creates a problem when running npx nuxi@latest init because the default nuxi template lacks a dependency on typescript which is a transitive required dependency for @typescript-eslint/typescript-estree

# This file contains the result of Yarn building a package (nuxt-app@workspace:.)
# Script name: postinstall

Nuxi 3.6.0

 ERROR  Cannot find module 'typescript'
Require stack:
- /Users/favna/workspace/temp/nuxt-app/node_modules/@typescript-eslint/typescript-estree/dist/convert.js
- /Users/favna/workspace/temp/nuxt-app/node_modules/@typescript-eslint/typescript-estree/dist/ast-converter.js
- /Users/favna/workspace/temp/nuxt-app/node_modules/@typescript-eslint/typescript-estree/dist/parser.js
- /Users/favna/workspace/temp/nuxt-app/node_modules/@typescript-eslint/typescript-estree/dist/index.js

  Require stack:
  - node_modules/@typescript-eslint/typescript-estree/dist/convert.js
  - node_modules/@typescript-eslint/typescript-estree/dist/ast-converter.js
  - node_modules/@typescript-eslint/typescript-estree/dist/parser.js
  - node_modules/@typescript-eslint/typescript-estree/dist/index.js
  at Module._resolveFilename (node:internal/modules/cjs/loader:1075:15)
  at Module._load (node:internal/modules/cjs/loader:920:27)
  at Module.require (node:internal/modules/cjs/loader:1141:19)
  at require (node:internal/modules/cjs/helpers:110:18)
  at Object.<anonymous> (node_modules/@typescript-eslint/typescript-estree/dist/convert.js:29:25)
  at Module._compile (node:internal/modules/cjs/loader:1254:14)
  at Module._extensions..js (node:internal/modules/cjs/loader:1308:10)
  at Module.load (node:internal/modules/cjs/loader:1117:32)
  at Module._load (node:internal/modules/cjs/loader:958:12)
  at Module.require (node:internal/modules/cjs/loader:1141:19)

@danielroe
Copy link
Member

danielroe commented Jun 23, 2023

Hotfixing in starter - thank you! We can track underlying issue in #21723.

@c-schwan c-schwan deleted the patch-1 branch June 23, 2023 18:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants