Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(nuxt): only remove one item from middleware #21730

Merged
merged 1 commit into from Jun 25, 2023
Merged

Conversation

danielroe
Copy link
Member

πŸ”— Linked issue

resolves #21701

❓ Type of change

  • πŸ“– Documentation (updates to the documentation or readme)
  • 🐞 Bug fix (a non-breaking change that fixes an issue)
  • πŸ‘Œ Enhancement (improving an existing functionality like performance)
  • ✨ New feature (a non-breaking change that adds functionality)
  • 🧹 Chore (updates to the build process or auxiliary tools and libraries)
  • ⚠️ Breaking change (fix or feature that would cause existing functionality to change)

πŸ“š Description

An embarassing one - a misaligned bracket meant we were removing all middleware when <NuxtLoadingIndicator> was present. I've also added an extra test to ensure the added middleware is still present

πŸ“ Checklist

  • I have linked an issue or discussion.
  • I have updated the documentation accordingly.

@danielroe danielroe self-assigned this Jun 23, 2023
@danielroe danielroe requested a review from manniL June 23, 2023 20:34
@danielroe danielroe merged commit c72bc95 into main Jun 25, 2023
28 checks passed
@danielroe danielroe deleted the fix/middleware-splice branch June 25, 2023 16:40
@github-actions github-actions bot mentioned this pull request Jun 25, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Global Middleware isn't called after layout switching
1 participant