Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(nuxt): inline global css with ssr: false route rule #21763

Merged
merged 2 commits into from Jun 25, 2023
Merged

Conversation

danielroe
Copy link
Member

πŸ”— Linked issue

resolves #21748
resolves #21760

❓ Type of change

  • πŸ“– Documentation (updates to the documentation, readme or JSdoc annotations)
  • 🐞 Bug fix (a non-breaking change that fixes an issue)
  • πŸ‘Œ Enhancement (improving an existing functionality like performance)
  • ✨ New feature (a non-breaking change that adds functionality)
  • 🧹 Chore (updates to the build process or auxiliary tools and libraries)
  • ⚠️ Breaking change (fix or feature that would cause existing functionality to change)

πŸ“š Description

With #21573, we now no longer emit global CSS in an entry.css file but instead inline it based on usage. This won't work with SPA mode by default as there is no usage tracking (even though we do explicitly add the entry file id to a modules set if it exists).

This fix ensures we have a modules set on ssrContext in which to inject the 'entry' module that is our source for inlining CSS.

πŸ“ Checklist

  • I have linked an issue or discussion.
  • I have updated the documentation accordingly.

@danielroe danielroe changed the title fix(nuxt): inline global css when ssr: false route rule is set fix(nuxt): inline global css with ssr: false route rule Jun 25, 2023
@danielroe danielroe merged commit 4cc9a71 into main Jun 25, 2023
28 checks passed
@danielroe danielroe deleted the fix/spa-css branch June 25, 2023 21:50
@github-actions github-actions bot mentioned this pull request Jun 25, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
1 participant