Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(nuxt): ensure static presets equivalent to nuxi generate #21860

Merged
merged 2 commits into from Jun 29, 2023

Conversation

danielroe
Copy link
Member

πŸ”— Linked issue

resolves #21254

❓ Type of change

  • πŸ“– Documentation (updates to the documentation or readme)
  • 🐞 Bug fix (a non-breaking change that fixes an issue)
  • πŸ‘Œ Enhancement (improving an existing functionality like performance)
  • ✨ New feature (a non-breaking change that adds functionality)
  • 🧹 Chore (updates to the build process or auxiliary tools and libraries)
  • ⚠️ Breaking change (fix or feature that would cause existing functionality to change)

πŸ“š Description

This finishes the second task on #21254. Previous we enabled static nitro preset in nuxi generate (#21655), but this follows up to ensure that running nuxi build --prerender (or NITRO_PRESET=static nuxi build have the same behaviour.

From this point, we no longer use options._generate flag but directly access nitro.options.static. We can remove the internal ._generate flag in a future minor release.

πŸ“ Checklist

  • I have linked an issue or discussion.
  • I have updated the documentation accordingly.

@stackblitz
Copy link

stackblitz bot commented Jun 29, 2023

Review PR in StackBlitz Codeflow Run & review this pull request in StackBlitz Codeflow.

Copy link
Member

@pi0 pi0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice changes

@danielroe danielroe changed the title fix(nuxt): ensure static presets are equivalent to nuxi generate fix(nuxt): ensure static presets equivalent to nuxi generate Jun 29, 2023
@danielroe danielroe merged commit 669e9bc into main Jun 29, 2023
28 checks passed
@danielroe danielroe deleted the fix/explicit-static branch June 29, 2023 09:14
@github-actions github-actions bot mentioned this pull request Jun 29, 2023
@Hebilicious
Copy link
Member

Does this means that nuxi generate is now strictly an alias of nuxi build --prerender ?

@danielroe
Copy link
Member Author

Yes πŸ‘

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

static nitro builds when running nuxi generate
3 participants