Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(nuxt): polyfill idle callback utils #21863

Merged
merged 3 commits into from Jul 19, 2023
Merged

feat(nuxt): polyfill idle callback utils #21863

merged 3 commits into from Jul 19, 2023

Conversation

logotip4ik
Copy link
Contributor

@logotip4ik logotip4ik commented Jun 29, 2023 •
edited

🔗 Linked issue

❓ Type of change

  • 📖 Documentation (updates to the documentation, readme or JSdoc annotations)
  • 🐞 Bug fix (a non-breaking change that fixes an issue)
  • 👌 Enhancement (improving an existing functionality like performance)
  • ✨ New feature (a non-breaking change that adds functionality)
  • 🧹 Chore (updates to the build process or auxiliary tools and libraries)
  • ⚠️ Breaking change (fix or feature that would cause existing functionality to change)

📚 Description

Exposes requestIdleCallback and cancelIdleCallback from #app.
Safari still does not support requestIdleCallback. Nuxt uses internal polyfill, thus forcing user to bundle two polyfills if they wanted to use requestIdleCallback. Why not to allow users to use already bundled polyfill ?

📝 Checklist

  • I have linked an issue or discussion.
  • I have updated the documentation accordingly.

@stackblitz
Copy link

stackblitz bot commented Jun 29, 2023

Review PR in StackBlitz Codeflow Run & review this pull request in StackBlitz Codeflow.

@danielroe
Copy link
Member

We could conceivably also add them to auto-imports.

@danielroe danielroe changed the title feat: expose idle callback polyfill from #app feat: polyfill requestIdleCallback and cancelIdleCallback Jun 29, 2023
@danielroe danielroe added this to the 3.7 milestone Jul 9, 2023
danielroe
danielroe approved these changes Jul 9, 2023
View reviewed changes
Copy link
Member

@danielroe danielroe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you ❤️

@danielroe danielroe changed the title feat: polyfill requestIdleCallback and cancelIdleCallback feat(nuxt): polyfill requestIdleCallback and cancelIdleCallback Jul 9, 2023
@danielroe danielroe changed the title feat(nuxt): polyfill requestIdleCallback and cancelIdleCallback feat(nuxt): polyfill idle callback utils Jul 19, 2023
@danielroe danielroe merged commit 22cccb0 into nuxt:main Jul 19, 2023
28 checks passed
@github-actions github-actions bot mentioned this pull request Jul 19, 2023
Merged
danielroe pushed a commit that referenced this pull request Jul 20, 2023
@logotip4ik
feat(nuxt): polyfill idle callback utils (#21863)
bea5ec3
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@danielroe danielroe danielroe approved these changes

Assignees
No one assigned
Labels
3.x enhancement 🍰 p2-nice-to-have
Projects
None yet
Milestone
3.7
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@logotip4ik @danielroe