Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(vite): fix issue detecting shadowed keyed composables #21891

Merged
merged 5 commits into from Jul 5, 2023

Conversation

ah-dc
Copy link
Contributor

@ah-dc ah-dc commented Jul 2, 2023

πŸ”— Linked issue

❓ Type of change

  • πŸ“– Documentation (updates to the documentation, readme or JSdoc annotations)
  • 🐞 Bug fix (a non-breaking change that fixes an issue)
  • πŸ‘Œ Enhancement (improving an existing functionality like performance)
  • ✨ New feature (a non-breaking change that adds functionality)
  • 🧹 Chore (updates to the build process or auxiliary tools and libraries)
  • ⚠️ Breaking change (fix or feature that would cause existing functionality to change)

πŸ“š Description

I'm sorry I wrote this silly bug :(

πŸ“ Checklist

  • I have linked an issue or discussion.
  • I have updated the documentation accordingly.

@danielroe
Copy link
Member

Thank you! Any chance we could add a regression test for this?

@ah-dc
Copy link
Contributor Author

ah-dc commented Jul 4, 2023

Thank you! Any chance we could add a regression test for this?

done but I have no idea why that one test failed

@danielroe
Copy link
Member

Thank you! I wouldn't worry about that failing test; it's a bit flaky. But the test seems to pass on the current main branch. πŸ€”

@danielroe danielroe changed the title fix(vite): source config of custom keyed composables don't work fix(vite): fix issue detecting shadowed keyed composables Jul 5, 2023
@danielroe danielroe merged commit e70ff83 into nuxt:main Jul 5, 2023
28 checks passed
@github-actions github-actions bot mentioned this pull request Jul 5, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants