Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(cli): add aliases to monorepo paths to tsconfig includes #21997

Merged
merged 3 commits into from Jul 14, 2023
Merged

fix(cli): add aliases to monorepo paths to tsconfig includes #21997

merged 3 commits into from Jul 14, 2023

Conversation

samydoesit
Copy link
Contributor

@samydoesit samydoesit commented Jul 6, 2023 •
edited by danielroe

🔗 Linked issue

resolves #21996

❓ Type of change

  • 📖 Documentation (updates to the documentation, readme or JSdoc annotations)
  • 🐞 Bug fix (a non-breaking change that fixes an issue)
  • 👌 Enhancement (improving an existing functionality like performance)
  • ✨ New feature (a non-breaking change that adds functionality)
  • 🧹 Chore (updates to the build process or auxiliary tools and libraries)
  • ⚠️ Breaking change (fix or feature that would cause existing functionality to change)

📚 Description

Add aliases to include property of tsconfig so that VSCode ts and intellisense works fine in a monorepo.

📝 Checklist

  • I have linked an issue or discussion.
  • I have updated the documentation accordingly.

@stackblitz
Copy link

stackblitz bot commented Jul 6, 2023

Review PR in StackBlitz Codeflow Run & review this pull request in StackBlitz Codeflow.

@samydoesit samydoesit force-pushed the add-missing-include-paths branch 2 times, most recently from 165c2ca to b6d7ac8 Compare July 9, 2023 15:11
@danielroe danielroe changed the title fix: add missing aliases in includes to tsconfig fix(cli): add aliases to other monorepo paths to tsconfig includes Jul 14, 2023
@danielroe danielroe added the cli label Jul 14, 2023
@danielroe danielroe changed the title fix(cli): add aliases to other monorepo paths to tsconfig includes fix(cli): add aliases to monorepo paths to tsconfig includes Jul 14, 2023
@danielroe danielroe merged commit 826f82a into nuxt:main Jul 14, 2023
28 checks passed
@github-actions github-actions bot mentioned this pull request Jul 14, 2023
Merged
@danielroe
Copy link
Member

danielroe commented Jul 14, 2023 •
edited

oops, my mistake - didn't mean to merge this with co-authored-by 🤦

thank you for this contribution ❤️

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@danielroe danielroe danielroe approved these changes

Assignees
No one assigned
Labels
3.x bug cli
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Importing components with alias in monorepo causes VSCode/Volar to fail finding modules/type declarations
2 participants
@samydoesit @danielroe