fix(nuxt): add baseURL to island fetch requests
#22009
Conversation
|
|
| @@ -79,7 +81,7 @@ export default defineComponent({ | |||
| appendResponseHeader(event, 'x-nitro-prerender', url) | |||
| } | |||
| // TODO: Validate response | |||
| const r = await eventFetch(withQuery(url, { | |||
| const r = await eventFetch(withQuery(join(appConfig.app.baseURL ?? '', url), { | |||
There was a problem hiding this comment.
Presumably this is only needed for prod+client, where we use globalThis.fetch?
There was a problem hiding this comment.
hmmm we can't really build the test/fixtures/basic directory due to #22010. But the issue is also happening in dev
There was a problem hiding this comment.
Ah, missed that.
We'll have to do this the other way then - omit the baseURL for dev+client (because we are using $fetch there which comes with it preconfigured).
|
Regarding setting |
|
Sure ! I'll convert this PR to draft. Will finish in a few days |
danielroe
changed the title
baseURL to island fetch requests
🔗 Linked issue
resolve #22002
resolve #22010
❓ Type of change
📚 Description
Hi 👋 this PR prepend the fetch request of
NuxtIslandwith the baseURL or it wouldn't correctly hit the endpoint of islands renderer📝 Checklist
@danielroe can i set a
app.baseURLforfixtures/basic?app.baseURLcrash due to prerender -> Prerendering is not working withapp.baseURL#22010todo
NUXT_APP_BASE_URLwithin fixtures tests