Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(vite): unpin vite from minor #22031

Merged
merged 1 commit into from Jul 19, 2023
Merged

feat(vite): unpin vite from minor #22031

merged 1 commit into from Jul 19, 2023

Conversation

danielroe
Copy link
Member

@danielroe danielroe commented Jul 7, 2023 •
edited

🔗 Linked issue

❓ Type of change

  • 📖 Documentation (updates to the documentation or readme)
  • 🐞 Bug fix (a non-breaking change that fixes an issue)
  • 👌 Enhancement (improving an existing functionality like performance)
  • ✨ New feature (a non-breaking change that adds functionality)
  • 🧹 Chore (updates to the build process or auxiliary tools and libraries)
  • ⚠️ Breaking change (fix or feature that would cause existing functionality to change)

📚 Description

This unpins vite from minor versions as it is now safe to rely on vite.experimental.renderBuiltUrl across new 4.x minors.

cc: @patak-dev

📝 Checklist

  • I have linked an issue or discussion.
  • I have updated the documentation accordingly.

@danielroe danielroe added this to the 3.7 milestone Jul 7, 2023
@danielroe danielroe self-assigned this Jul 7, 2023
@stackblitz
Copy link

stackblitz bot commented Jul 7, 2023

Review PR in StackBlitz Codeflow Run & review this pull request in StackBlitz Codeflow.

@danielroe danielroe merged commit 3828a6e into main Jul 19, 2023
28 checks passed
@danielroe danielroe deleted the chore/unpin-vite branch July 19, 2023 15:24
@github-actions github-actions bot mentioned this pull request Jul 19, 2023
Merged
@patak-dev
Copy link

Leaving a reference to the discussion to gather feedback about stabilizing experimental.renderBuiltUrl in Vite 5:

danielroe added a commit that referenced this pull request Jul 20, 2023
@danielroe
feat(vite): unpin vite from minor (#22031)
42284c9
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@danielroe danielroe

Labels
3.x chore vite
Projects
None yet
Milestone
3.7
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@danielroe @patak-dev