Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(nuxt): skip view transitions where there is no route change #22140

Merged
merged 2 commits into from Jul 14, 2023

Conversation

Jannchie
Copy link
Contributor

πŸ”— Linked issue

#20977

❓ Type of change

  • πŸ“– Documentation (updates to the documentation, readme or JSdoc annotations)
  • 🐞 Bug fix (a non-breaking change that fixes an issue)
  • πŸ‘Œ Enhancement (improving an existing functionality like performance)
  • ✨ New feature (a non-breaking change that adds functionality)
  • 🧹 Chore (updates to the build process or auxiliary tools and libraries)
  • ⚠️ Breaking change (fix or feature that would cause existing functionality to change)

πŸ“š Description

Resolves #20977

πŸ“ Checklist

  • I have linked an issue or discussion.
  • I have updated the documentation accordingly.

@stackblitz
Copy link

stackblitz bot commented Jul 14, 2023

Review PR in StackBlitz Codeflow Run & review this pull request in StackBlitz Codeflow.

Copy link
Member

@danielroe danielroe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We also need to check whether the components will change by verifying whether components will change by looking into the matched property. (If they don't, then page:finish won't be called and the transition will abort.)

Alternatively, we can update view-transitions implementation so finishTransition is called after the route updates, even if there has been no call of page:finish.

@danielroe danielroe changed the title fix: view transition in same page fix(nuxt): skip view transitions where there is no route change Jul 14, 2023
@danielroe danielroe merged commit 988e75b into nuxt:main Jul 14, 2023
28 checks passed
@github-actions github-actions bot mentioned this pull request Jul 14, 2023
@Jannchie Jannchie deleted the fix/view-transitions branch December 11, 2023 15:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

experimental.viewTransition + Anchor point link will cause temporary page downtime
2 participants