Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(nuxi): support --inspect in dev mode #22205

Merged
merged 2 commits into from Jul 19, 2023

Conversation

Seboran
Copy link
Contributor

@Seboran Seboran commented Jul 18, 2023

πŸ”— Linked issue

resolves #21312

❓ Type of change

  • πŸ“– Documentation (updates to the documentation, readme or JSdoc annotations)
  • 🐞 Bug fix (a non-breaking change that fixes an issue)
  • πŸ‘Œ Enhancement (improving an existing functionality like performance)
  • ✨ New feature (a non-breaking change that adds functionality)
  • 🧹 Chore (updates to the build process or auxiliary tools and libraries)
  • ⚠️ Breaking change (fix or feature that would cause existing functionality to change)

πŸ“š Description

Adds the inspector option if present.

I don't know a lot about inspector options but this bug affects me so I gave it a try.

I mostly took inspiration from packages/nuxi/src/cli.ts

πŸ“ Checklist

  • I have linked an issue or discussion.
  • I have updated the documentation accordingly.

@stackblitz
Copy link

stackblitz bot commented Jul 18, 2023

Review PR in StackBlitz Codeflow Run & review this pull request in StackBlitz Codeflow.

Copy link
Member

@pi0 pi0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice! LGTM as an experimental feature. We need to rework this for next gen cli ~> nuxt/cli#73

@danielroe danielroe merged commit fb77cc0 into nuxt:main Jul 19, 2023
28 checks passed
@danielroe danielroe changed the title fix(nuxi): fixes inspect debugger fix(nuxi): support --inspect in dev mode Jul 19, 2023
@danielroe
Copy link
Member

Thank you ❀️

This was referenced Jul 19, 2023
@carbdias
Copy link

How can we use this? Does it console.log things to navigator inspector ? Or inside Visual Studio Code?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Running Nuxt 3 development server with debugging mode not available?
4 participants